Add FormationError and OccurrenceConstraintViolationError
#490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. I've updated the title and description of this ticket to be bit more descriptive. These elements will end up |
OrangeTux
previously approved these changes
Oct 19, 2023
OrangeTux
changed the title
FormationError and OccurrenceConstraintViolationError
|
@OrangeTux I've just corrected the comment, could you please confirm? |
OrangeTux
approved these changes
Oct 23, 2023
Jared-Newell-Mobility
deleted the
FormatViolation-serialization-bug-with-OCPP-1.6-J
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In OCPP 1.6, two errors were misspelled. "FormationViolation" Error should be "FormatViolation" Error, "OccurenceConstraintViolation" Error should be "OccurrenceConstraintViolation" Error.
The OCA decided not to correct the spelling in OCPP 1.6, since that would be a breaking change. FormationViolation has been fixed as of OCPP 2.0.1. OccurenceConstraintViolation Error is used for 1.6 and 2.0.1. "OccurrenceConstraintViolation" Error is used for OCPP 2.1 and up.
This library doesn't support "FormationViolation" Error (for OCPP 1.6 and up)
This commit adds support for those errors.
See the discussion at #381 and OCPP 1.6-J Errata sheet v1.0, section 5 "Known issues that won't be fixed".