Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong type in ocpp.ocpp.v201.datatypes.ReportDataType.variable_attribute that yiedl a failure in the validation of the Payload #553

Closed
AlfredoNaef opened this issue Dec 22, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@AlfredoNaef
Copy link

Hello,

When sending the payload for NotifyReportRequest (with also the optional field report_data in the payload) it fails at the validation with the json schema. After some digging, I found out that the problem is due to the data type for ReportDataType.variable_attribute, that in the latets release of your code is defined as VariableAttributeType. However, it should be List[VariableAttributeType] because in the json schema for NotifyReportRequest the equivalent field variableAttribute is defined as array. As such, for easier usage by users of your library you should change the type as I suggested.

@AlfredoNaef AlfredoNaef added the bug Something isn't working label Dec 22, 2023
@Jared-Newell-Mobility
Copy link
Contributor

Thanks for raising the issue - this is covered in the PR #529 so I will close this for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants