Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataclass MessageInfoType in ocpp201 has different attribute name than in json Schema for NotifyDisplayMessagesRequest #548

Closed
AlfredoNaef opened this issue Dec 20, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@AlfredoNaef
Copy link

Hello,

I am currently using your library to implement OCPP 2.0.1 fro my company. While, testing that my implemnetation of the messages at least are sent, recieved and answered, I noticed that for NotifyDisplayMessagesRequest the Pyaload is not sent. After some digging, I found that if in NotifyDisplayMessagesPayload in the attribute message_info I provide the MessageInfoType and inside this dataclass I also define the attribute end_data_time, then the payload is not sent because it fails the validation with the json schema for NotifyDisplayMessagesRequest. Specifically, in MessageInfoType.end_data_time is a typo and should be MessageInfoType.end_date_time, because in the json schema the field is called endDateTime. In conclusion, to fix this bug you just need to rename the attribute in MessageInfoType from end_data_time to end_date_time (it's just a simple e instead of a).

@AlfredoNaef AlfredoNaef added the bug Something isn't working label Dec 20, 2023
@Jared-Newell-Mobility
Copy link
Contributor

Thanks, nice catch - a PR has been opened #549

@Jared-Newell-Mobility
Copy link
Contributor

Merged and will be included in the next minor release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants