fix(locator): do not swallow driver errors in isVisible#138
Merged
gmegidish merged 2 commits intoMay 21, 2026
Merged
Conversation
Member
|
@JustasMonkev can you please sign the commit? if that's a problem, I can re-create this change in a new branch and tag you as contrib. |
Contributor
Author
Sure I can do it |
JustasMonkev
force-pushed
the
fix/is-visible-rethrow-driver-errors
branch
2 times, most recently
from
May 21, 2026 15:28
9507ac5 to
80505aa
Compare
JustasMonkev
force-pushed
the
fix/is-visible-rethrow-driver-errors
branch
from
May 21, 2026 15:33
80505aa to
1b761ad
Compare
Contributor
Author
|
Done @gmegidish |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Locator.isVisible()so it only returnsfalsefor expected locator lookup failures.Previously,
isVisible()caught every thrown error and returnedfalse. That could hide real driver/session/device failures, for example if the device disconnected while reading the view hierarchy.