Skip to content
This repository has been archived by the owner on Aug 5, 2020. It is now read-only.

Definition of escape for escapedHTMLString() #133

Open
vmarta opened this issue Apr 25, 2013 · 1 comment
Open

Definition of escape for escapedHTMLString() #133

vmarta opened this issue Apr 25, 2013 · 1 comment
Assignees

Comments

@vmarta
Copy link
Contributor

vmarta commented Apr 25, 2013

Why is escapedHTMLString() called as it is now? Shouldn't it be unescapedHTMLString() perhaps?

In the doc's Quick Start page, the main.js sample has this comment:

// To escape content, we prepend resources with "x-",
// so to change the src, you must set x-src.

In this case, the word 'escape' means adding the prefix.

However, that meaning is contradicted with what escapedHTMLString() does:

Returns a string representation of the captured document, but with all resources enabled (prefix removed).

What's the correct definition of 'escape'? Thanks.

@ghost ghost assigned jansepar Apr 25, 2013
@jansepar
Copy link
Contributor

jansepar commented Oct 3, 2013

You're totally right @vmarta, it should be enabledHTMLString! Sorry for taking a bigillian years to get to this :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants