Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require MNE 1.0 or above #479

Open
rob-luke opened this issue Sep 11, 2022 · 5 comments
Open

Require MNE 1.0 or above #479

rob-luke opened this issue Sep 11, 2022 · 5 comments
Milestone

Comments

@rob-luke
Copy link
Member

There are a number of places in the code where we have something like remove once MNE 1.0 is required.
I would like to enforce that MNE 1.0+ is required for MNE-NIRS to reduce the required maintenance.
What are your thoughts on this @larsoner? I know MNE-Python gives longer support, but these side packages don't have the same size development team.

@larsoner
Copy link
Member

Most downstream mne- packages only support the latest release and main. So you could bump to 1.1 already here

@rob-luke
Copy link
Member Author

Awesome, I will make a note about that in the docs and pull out that code as I see it.

@rob-luke rob-luke added this to the v0.4.0 milestone Sep 12, 2022
@rob-luke
Copy link
Member Author

Most downstream mne- packages only support the latest release and main

Great, when MNE-Python 1.4 is released lets add this constraint to the requirements and environment.yml files.

When is the next MNE release roughly scheduled @larsoner ? (I should also get back on discord, sorry)

@larsoner
Copy link
Member

In the next week or two

@rob-luke
Copy link
Member Author

Well, that's just worked out dandy then ;)
Good time for some spring cleaning in MNE-NIRS too then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants