Update to mmtk-core PR#647 #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinsoon
added a commit
to mmtk/mmtk-core
that referenced
this pull request
Sep 13, 2022
This PR refactors metadata, and makes all its access associated with a num type. This PR also greatly reduces code duplication in the metadata module, and adds tests for both header metadata and side metadata access. Metadata in the following context refers to both side metadata and header metadata. * All metadata access functions are moved to `HeaderMetadata`/`SideMetadata` as methods. * Introduce the `MetadataValue` trait so we can handle `u8/16/32/64/size` uniformly. * All metadata access methods needs a number type for the get/set value type. It needs to match what is defined in the spec, otherwise it will panic. * Fixe the issue for `u64` metadata on 32 bits. It should work properly now. * Add unit tests. * Header metadata methods in `ObjectModel` now have a default implementation that uses our header metadata module. Related PRs: * mmtk/mmtk-openjdk#178 * mmtk/mmtk-jikesrvm#122 * mmtk/mmtk-v8#67
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates mmtk-core to mmtk/mmtk-core#647.