-
Notifications
You must be signed in to change notification settings - Fork 10
Update Julia upstream 43bf2c8 #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR is not ready to merge. Somehow, sticky immix failed to build on the dev machine I am using. It seems like some objects that should be alive are collected by the GC. It could be related with write barrier, I did not look further into it. |
This is fixed in mmtk/julia@8eab37d. It turns out that there is an object update that does not have a write barrier in Julia code. So the bug exists in |
This PR changes `VMSpace` to multiple discontiguous regions as VM space. This PR is used in mmtk/mmtk-julia#71 to support system and package images. * add an `ExternalPageResource` to manage the discontiguous regions. * implement `VMSpace` with `ExternalPageResource`. `VMSpace` no longer uses `ImmortalSpace`. * rename `lazy_init_vm_space` to `set_vm_space`, as we allow setting vm space multiple times with non overlapping regions. --------- Co-authored-by: Kunal Sareen <kunal.sareen@anu.edu.au>
This PR changes `VMSpace` to multiple discontiguous regions as VM space. This PR is used in mmtk/mmtk-julia#71 to support system and package images. * add an `ExternalPageResource` to manage the discontiguous regions. * implement `VMSpace` with `ExternalPageResource`. `VMSpace` no longer uses `ImmortalSpace`. * rename `lazy_init_vm_space` to `set_vm_space`, as we allow setting vm space multiple times with non overlapping regions. --------- Co-authored-by: Kunal Sareen <kunal.sareen@anu.edu.au>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
# This seems to be a regression from upstream when we merge with upstream 43bf2c8. | ||
# The required string int.jl does not appear in the output even if I test with the stock Julia code. | ||
# I do not know what is wrong, but at this point, I dont want to spend time on it. | ||
'@test occursin("int.jl", code)' "$JULIA_PATH/test/cmdlineargs.jl" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is odd, but I guess it might just be a bug in their master. If it doesn't work even with stock Julia, then I agree we shouldn't worry about it.
Updates to mmtk/julia#21.