Add pointer pinning to handle internal pointers. Use jl_active_task_stack.
#217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinsoon
changed the title
jl_active_task_stack.
Updating `dev`. Merge with mmtk/julia#85. --------- Co-authored-by: Stephen Kell <srk31-github@srcf.ucam.org> Co-authored-by: Yi Lin <qinsoon@gmail.com> Co-authored-by: Luis Eduardo de Souza Amorim <eduardo@rat.moma>
|
julia-version |
udesou
reviewed
Feb 5, 2025
mmtk/src/api.rs
Outdated
| pub extern "C" fn mmtk_pin_pointer(addr: Address) -> bool { | ||
| crate::early_return_for_non_moving_build!(false); | ||
| if mmtk_object_is_managed_by_mmtk(addr.as_usize()) { | ||
| if !crate::object_model::is_addr_in_immixspace(addr) { |
There was a problem hiding this comment.
You only need to pin objects in the immixspace, correct? Wouldn't be enough to do a single check if crate::object_model::is_addr_in_immixspace(addr) instead of having the check mmtk_object_is_managed_by_mmtk(addr.as_usize()) ?
There was a problem hiding this comment.
Yes. It should be fine. I made the change.
qinsoon
added a commit
to qinsoon/mmtk-julia
that referenced
this pull request
Feb 6, 2025
…stack`. (mmtk#217) This PR adds pinning that handles internal pointers. It also uses `jl_active_task_stack` for stack scanning instead of `jl_task_stack_buffer`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds pinning that handles internal pointers. It also uses
jl_active_task_stackfor stack scanning instead ofjl_task_stack_buffer.