spawn_gc_thread API change

Author: wks

mmtk/Cargo.lock

@@ -31,7 +31,7 @@ lazy_static = "1.1"
 # - change branch
 # - change repo name
 # But other changes including adding/removing whitespaces in commented lines may break the CI
-mmtk = { git = "https://github.com/wks/mmtk-core.git", rev="7cb0b2c12be341c084e03f2cd943fad8ac088f83" }
+mmtk = { git = "https://github.com/wks/mmtk-core.git", rev="fb752a41c67fb3a3f4ea7223c11acf099eb20131" }
 # Uncomment the following to build locally
 # mmtk = { path = "../repos/mmtk-core" }
 log = {version = "0.4", features = ["max_level_trace", "release_max_level_off"] }

mmtk/Cargo.toml

@@ -3,6 +3,7 @@ use crate::{SINGLETON, UPCALLS};
 use log::{info, trace};
 use mmtk::util::alloc::AllocationError;
 use mmtk::util::opaque_pointer::*;
+use mmtk::vm::gc_thread::UnimplementedGCThreadJoinHandle;
 use mmtk::vm::{Collection, GCThreadContext};
 use mmtk::Mutator;
 use std::sync::atomic::{AtomicBool, AtomicIsize, AtomicU64, Ordering};
@@ -71,7 +72,10 @@ impl Collection<JuliaVM> for VMCollection {
         info!("Finished blocking mutator for GC!");
     }
 
-    fn spawn_gc_thread(_tls: VMThread, ctx: GCThreadContext<JuliaVM>) {
+    fn spawn_gc_thread(
+        _tls: VMThread,
+        ctx: GCThreadContext<JuliaVM>,
+    ) -> UnimplementedGCThreadJoinHandle {
         // Just drop the join handle. The thread will run until the process quits.
         let _ = std::thread::spawn(move || {
             use mmtk::util::opaque_pointer::*;
@@ -85,6 +89,8 @@ impl Collection<JuliaVM> for VMCollection {
                 }
             }
         });
+
+        UnimplementedGCThreadJoinHandle
     }
 
     fn schedule_finalization(_tls: VMWorkerThread) {}

mmtk/src/collection.rs

@@ -6,6 +6,7 @@ extern crate lazy_static;
 
 use mmtk::util::opaque_pointer::*;
 use mmtk::util::Address;
+use mmtk::vm::gc_thread::UnimplementedGCThreadJoinHandle;
 use mmtk::vm::VMBinding;
 use mmtk::MMTKBuilder;
 use mmtk::MMTK;
@@ -48,6 +49,8 @@ impl VMBinding for JuliaVM {
     type VMReferenceGlue = reference_glue::VMReferenceGlue;
     type VMMemorySlice = edges::JuliaMemorySlice;
     type VMEdge = JuliaVMEdge;
+
+    type VMGCThreadJoinHandle = UnimplementedGCThreadJoinHandle;
 }
 
 /// This is used to ensure we initialize MMTk at a specified timing.