Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public API check is not always correct #1167

Open
qinsoon opened this issue Jul 11, 2024 · 1 comment
Open

Public API check is not always correct #1167

qinsoon opened this issue Jul 11, 2024 · 1 comment
Labels
A-ops Area: Operations (e.g. CI)

Comments

@qinsoon
Copy link
Member

qinsoon commented Jul 11, 2024

For #1165, the return value for memory_manager::is_mmtk_object is changed. However, in the run https://github.com/mmtk/mmtk-core/actions/runs/9899721290/job/27349183033, the change for is_mmtk_object is not listed.

cargo public-api diff origin/${GITHUB_BASE_REF}..1bb2d14ef68b9fb5a81f6a6ca7b941f3f22c6fe8 --deny=all
...

Removed items from the public API
=================================
(none)

Changed items in the public API
===============================
(none)

Added items to the public API
=============================
+pub unsafe fn mmtk::util::metadata::side_metadata::SideMetadataSpec::find_prev_non_zero_value<T: mmtk::util::metadata::MetadataValue>(&self, data_addr: mmtk::util::address::Address, search_limit_bytes: usize) -> core::option::Option<mmtk::util::address::Address>
+pub unsafe fn mmtk::util::metadata::side_metadata::SideMetadataSpec::load_raw_byte(&self, data_addr: mmtk::util::address::Address) -> u8
+pub unsafe fn mmtk::util::metadata::side_metadata::SideMetadataSpec::load_raw_word(&self, data_addr: mmtk::util::address::Address) -> usize
+pub const fn mmtk::util::metadata::side_metadata::SideMetadataSpec::uses_contiguous_side_metadata(&self) -> bool
+impl core::cmp::Eq for mmtk::util::options::PlanSelector
+impl core::cmp::PartialEq for mmtk::util::options::PlanSelector
+pub fn mmtk::util::options::PlanSelector::eq(&self, other: &mmtk::util::options::PlanSelector) -> bool
+impl core::marker::StructuralPartialEq for mmtk::util::options::PlanSelector
@qinsoon qinsoon added the A-ops Area: Operations (e.g. CI) label Jul 11, 2024
@k-sareen
Copy link
Collaborator

Perhaps it's because the is_mmtk_object feature is not turned on for the API check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ops Area: Operations (e.g. CI)
Projects
None yet
Development

No branches or pull requests

2 participants