Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"You may also enjoy" recommends hidden posts, when it probably shouldn't #4653

Closed
alichtman opened this issue Jan 14, 2024 · 1 comment
Closed

Comments

@alichtman
Copy link

alichtman commented Jan 14, 2024

What happened?

Expected behavior

I have a hidden post in my repo.

When I set related: true in my _config.yml file, like:

# Defaults
defaults:
  # _posts
  - scope:
      path: ""
      type: posts
    values:
      show_date: true
      layout: single
      author_profile: true
      read_time: true
      comments: # true
      share: true
      related: true  ## Problem!

The hidden post is recommended. It probably shouldn't be!

Steps to reproduce the behavior

  • Add post that is set to hidden
  • Enable recommended posts
  • See that hidden post is recommended

Other

No response

@iBug iBug closed this as completed in 60b9565 Apr 23, 2024
@iBug
Copy link
Collaborator

iBug commented Apr 23, 2024

Fixed. Will be available as of next release (probably 4.26). You can use remote_theme: "mmistakes/minimal-mistakes@master" for the time being if you want to try it out.

minyoongi96 pushed a commit to minyoongi96/minyoongi96.github.io that referenced this issue Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants