-
Notifications
You must be signed in to change notification settings - Fork 25.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Categories & tags show locally but not on github pages #329
Comments
BTW, really love the theme 👍 thanks for all your hard work! Also worth mentioning, the tags/categories are being recognized by the archive pages: |
Quick glance at your repo and nothing is standing out to me. Not sure what's going on. The fact that it works locally and not when pushed is strange, I'm stumped. The only thing I can think of is the Liquid conditonals that trigger category and tag lists aren't being met. The GitHub Pages gem was recently updated so maybe something changed or broke. But I doubt it since they're working fine for the MM theme demo that is hosted on GH same as your site. You don't get any error reports or anything when pushing? |
Thanks for the quick response Mike! Nope, all green on the settings page of the repo. Not sure if it is due to not being nested under a I snooped over the forks of your repo and see this elsewhere as well: https://github.com/ivyleavedtoadflax/ivyleavedtoadflax.github.io/blob/master/_posts/2016-02-22-infographic3.md which is rendered at http://www.machinegurning.com/rstats/infographic3/ for example. |
Hrmmm. Looks like you are correct on that conditional statement. trevorstephens/trevorstephens.github.io@eda2cff http://trevorstephens.github.io/ramblings/a-journey-begins/ gets the 'foo' |
To rule out the updated GitHub Pages gem try the following:
You could also just rip some of the |
Sounds like something might have changed then. I'll have to do some testing when I'm in front of a computer. Probably need to modify that conditional if I can reproduce what's going on. |
Thanks again Mike. Updated the bundle packages and the tags are gone locally now as well. |
Getting 'foo' on local build as well. |
The updates were:
|
…h site.tags and site.categories - Fixes #329
I just posted a fix. For whatever reason This was causing a few things to break. Best I can tell something changed with The fix is to update the following 3 files. |
Thanks Mike! Just posted to the githubs and it's looking great! 👍 😄 |
Excellent. Thanks for pointing out the bug. |
My pleasure. Thanks for creating such a great theme and taking care of issues so quickly! |
For those landing here and only want this one fix the theme upgrade instructions can be modified as such:
You'll have some merge conflicts to resolve in |
…h site.tags and site.categories - Fixes mmistakes#329
…h site.tags and site.categories - Fixes mmistakes#329
…h site.tags and site.categories - Fixes mmistakes#329
Add Halve theme
…h site.tags and site.categories - Fixes mmistakes#329
…h site.tags and site.categories - Fixes mmistakes#329
As the title says, when I build locally the category and tags display at the bottom of the post, but when I push to github, they are missing. Repo here.
Example outputs:
Locall y @
http://127.0.0.1:4000/ramblings/a-journey-begins/
:Github:
The text was updated successfully, but these errors were encountered: