Skip to content

duplicate disqus_thread in HTML id #1199

Closed
@fantasticfears-stage

Description

@fantasticfears-stage
  • This is a question about using the theme.
    This is a feature request.
    I have updated all gems with bundle update.
    I have tested locally with bundle exec jekyll build.
    I believe this to be a bug with the theme --- not Jekyll, GitHub Pages or one of the bundled plugins.

Environment informations

  • Minimal Mistakes version: 4.5.1
  • github-pages: 155
  • Operating system: OS X 10.12.6

Expected behavior

No duplicate id for disqus_thread in HTML.

Steps to reproduce the behavior

Build with comments.disqus.shortname, the output HTML has the duplicate id in HTML.

Activity

mmistakes

mmistakes commented on Aug 23, 2017

@mmistakes
Owner

You have a public repo somewhere I can inspect? Hard to tell what's going on without seeing your actual _config.yml and post content.

mmistakes

mmistakes commented on Aug 23, 2017

@mmistakes
Owner

Got it. Looks like this was from #1179

<div id="disqus_thread"></div> was added to _includes/comments-providers/disqus.html when it shouldn't have been.

self-assigned this
on Aug 28, 2017
added a commit that references this issue on May 30, 2019
e44960f
added a commit that references this issue on May 18, 2022
779f384
added a commit that references this issue on May 5, 2023
3ae4fed
added a commit that references this issue on Mar 15, 2024
0d87190
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

    Participants

    @mmistakes@fantasticfears-stage

    Issue actions

      duplicate `disqus_thread` in HTML id · Issue #1199 · mmistakes/minimal-mistakes