Closed
Description
google-plus comments provider seems to be stuck on loading. Didn't really see any javascript error on console.
- This is a feature request.This is a question about using the theme.I have updated all gems with
bundle update
.I have tested locally withbundle exec jekyll build
.I believe this to be a bug with the theme --- not Jekyll, GitHub Pages or one of the bundled plugins.
Environment informations
Latest minimal-mistakes version
OS: Windows: Chrome/Linux: Firefox
Steps to reproduce the behavior
To reproduce, try to add comments after enabling google-plus commenting.
page: zmsp.github.io/hardware/cryptocurrency/gfx-too-high/
repo: github.com/zmsp/zmsp.github.io
Activity
mmistakes commentedon Jul 3, 2017
Not sure what's going on. I'm not seeing any script errors. Only thing I can think of Google changed the API or deprecated something.
To get this working originally I followed some instructions from a random blog post. I never could find official documentation from Google on how to embed G+ comments on a website. Wouldn't surprise me at all if they turned this feature off for new posts as they've been scaling back the whole G+ thing the last couple of years.
If you can find some documentation on how to fix or implement it directly from the horse's mouth I'll happily apply it.
zmsp commentedon Jul 4, 2017
This change fixed it. I am not familiar with how it loads the comment box so its not the most elegant. But let me know if you want the change and I can submit a pull request. zmsp/zmsp.github.io@23914d3
changes on _includes/comments.html
Pulled from here: https://floaternet.com/gcomments
mmistakes commentedon Jul 4, 2017
A PR with this fix would be great.
Avoid Liquid failure with empty collections (mmistakes#1092)