From 5511720ca1cfe5e9ae4a935ca751e24761533882 Mon Sep 17 00:00:00 2001 From: Andrea Barbadoro Date: Tue, 7 Nov 2023 15:01:26 +0100 Subject: [PATCH] archival/upload_housekeeping_service: log error for unknown exception --- src/v/archival/upload_housekeeping_service.cc | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/v/archival/upload_housekeeping_service.cc b/src/v/archival/upload_housekeeping_service.cc index 73cc8be0b467..5d0f2a09065d 100644 --- a/src/v/archival/upload_housekeeping_service.cc +++ b/src/v/archival/upload_housekeeping_service.cc @@ -376,12 +376,13 @@ ss::future<> housekeeping_workflow::run_jobs_bg() { _running.splice(_running.begin(), _pending, _pending.begin()); { ss::gate::holder hh(_exec_gate); + auto job_name = _running.front().name(); try { auto r = exec_timer.time(); vlog( archival_log.debug, "Running job {} with quota {}", - _running.front().name(), + job_name, quota); auto& job = _running.front(); @@ -404,8 +405,9 @@ ss::future<> housekeeping_workflow::run_jobs_bg() { // Shutting down } catch (...) { vlog( - archival_log.warn, - "upload housekeeping job error: {}", + archival_log.error, + "upload housekeeping job {} error: {}", + job_name, std::current_exception()); jobs_failed++; maybe_update_probe(