check with new paradox

[mb706]

No description provided.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.61%. Comparing base (52be12d) to head (fb386fc).

❗ Current head fb386fc differs from pull request most recent head e7f8ac4. Consider uploading reports for the commit e7f8ac4 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #234   +/-   ##
=======================================
  Coverage   80.61%   80.61%           
=======================================
  Files          31       31           
  Lines        2074     2074           
=======================================
  Hits         1672     1672           
  Misses        402      402           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sebffischer]

Hey @pat-s, we are currently in the process of migrating to the new "S3 paradox". To release the new paradox on CRAN without breaking any reverse dependencies it would be great if you could merge this PR and make a new CRAN release! :)

[sebffischer]

The failing tests seem to be snapshot tests

[pat-s]

I have to make a new CRAN release in the next weeks anyhow as I got a mail from CRAN.

I wonder though why this change comes with a full CI suite change. If so, the other one would need to be removed. It looks like a central CI definition for the whole org, so it would likely be the best to adopt it.

The test failures also appear in main, so they are likely unrelated, yes.

[sebffischer]

Thanks!

Parts of the CI suite are intended to test with dev versions of paradox and bbotk to ensure that the old -> new paradox transition runs smoothly.

Regarding the org-wide CI definitions, they can be found here: https://github.com/mlr-org/actions

[pat-s]

@sebffischer Seems to work. Should this PR be included in the next release? I.e. is paradox waiting for all packages to be updated first?

[sebffischer]

@pat-s yes exactly, it would be great if you could include this in the next release!

[pat-s]

After the workflows were successfull, can I remove them again before merging? Or should I keep them around until paradox got updated?

[sebffischer]

Martin's idea is to have them in the main branch to ensure that any changes that are made to mlr3 packages before paradox is released are also tested against the new S3 paradox version. So ideally they should be kept there until paradox is released, but then they can be removed