Skip to content

Commit 542bfbc

Browse files
committed
new sugar functions
1 parent 56608e2 commit 542bfbc

File tree

3 files changed

+5
-7
lines changed

3 files changed

+5
-7
lines changed

R/Filter.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ Filter = R6Class("Filter",
111111

112112
calculate = function(task, nfeat = NULL) {
113113

114-
task = assert_task(task, feature_types = self$feature_types, task_properties = self$task_properties)
114+
task = assert_task(as_task(task), feature_types = self$feature_types, task_properties = self$task_properties)
115115
fn = task$feature_names
116116

117117
if (task$nrow == 0L) {

R/FilterImportance.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ FilterImportance = R6Class("FilterImportance", inherit = Filter,
2121
public = list(
2222
learner = NULL,
2323
initialize = function(id = "importance", learner = "classif.rpart") {
24-
self$learner = learner = assert_learner(learner, properties = "importance", clone = TRUE)
24+
self$learner = learner = assert_learner(as_learner(learner, clone = TRUE), properties = "importance")
2525

2626
super$initialize(
2727
id = id,

R/FilterPerformance.R

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,9 @@ FilterPerformance = R6Class("FilterPerformance", inherit = Filter,
2525
measure = NULL,
2626

2727
initialize = function(id = "performance", learner = "classif.rpart", resampling = "holdout", measure = NULL) {
28-
self$learner = learner = assert_learner(learner, properties = "importance", clone = TRUE)
29-
self$resampling = assert_resampling(resampling)
30-
if (is.null(measure))
31-
measure = head(default_measures(learner$task_type), 1L)
32-
self$measure = assert_measure(measure, learner = learner)
28+
self$learner = learner = assert_learner(as_learner(learner, clone = TRUE), properties = "importance")
29+
self$resampling = assert_resampling(as_resampling(resampling))
30+
self$measure = assert_measure(as_measure(measure, task_type = learner$task_type, clone = TRUE), learner = learner)
3331

3432
super$initialize(
3533
id = id,

0 commit comments

Comments
 (0)