Added padding to artifact text viewer #6778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shraddha Falane <falane.shraddha18@gmail.com>
github-actions
bot
added
area/uiux
Member
padding: 0px
padding: 3px
padding: 5px
padding: 10px
|
Signed-off-by: Shraddha Falane <falane.shraddha18@gmail.com>
Contributor
Author
|
5 px looks good. I've change it. |
BenWilson2
added a commit
that referenced
this pull request
Sep 19, 2022
…el (#6807) * Added padding to artifact text viewer (#6778) * Added padding to artifact text viewer Signed-off-by: Shraddha Falane <falane.shraddha18@gmail.com> * Modified padding for artifact text viewer Signed-off-by: Shraddha Falane <falane.shraddha18@gmail.com> Signed-off-by: Shraddha Falane <falane.shraddha18@gmail.com> Signed-off-by: Ivan Križanić <ikrizanic@croz.net> * Implemented `unwrap_python_model()` method in mlflow.pyfunc.PyFuncModel Signed-off-by: Ivan Križanić <ikrizanic@croz.net> * Simplified unwrap_python_model and added test for it Signed-off-by: Ivan Križanić <ikrizanic@croz.net> * Fixed lint and test errors Signed-off-by: Ivan Križanić <ikrizanic@croz.net> * Remove unused imports Signed-off-by: Ivan Križanić <ikrizanic@croz.net> * Update mlflow/pyfunc/__init__.py Co-authored-by: Ben Wilson <39283302+BenWilson2@users.noreply.github.com> Signed-off-by: Ivan Križanić <38288854+ikrizanic@users.noreply.github.com> Signed-off-by: Ivan Križanić <ikrizanic@croz.net> * reverted change in ShowArtifactTextView.js Signed-off-by: Ivan Križanić <ikrizanic@croz.net> * Optimized imports and reformated with black Signed-off-by: Ivan Križanić <ikrizanic@croz.net> Signed-off-by: Shraddha Falane <falane.shraddha18@gmail.com> Signed-off-by: Ivan Križanić <ikrizanic@croz.net> Signed-off-by: Ivan Križanić <38288854+ikrizanic@users.noreply.github.com> Co-authored-by: Shraddha Falane <72125392+shraddhafalane@users.noreply.github.com> Co-authored-by: Ivan Križanić <ikrizanic@croz.net> Co-authored-by: Ben Wilson <39283302+BenWilson2@users.noreply.github.com>
nnethery
pushed a commit
to nnethery/mlflow
that referenced
this pull request
Feb 1, 2024
* Added padding to artifact text viewer Signed-off-by: Shraddha Falane <falane.shraddha18@gmail.com> * Modified padding for artifact text viewer Signed-off-by: Shraddha Falane <falane.shraddha18@gmail.com> Signed-off-by: Shraddha Falane <falane.shraddha18@gmail.com>
nnethery
pushed a commit
to nnethery/mlflow
that referenced
this pull request
Feb 1, 2024
…el (mlflow#6807) * Added padding to artifact text viewer (mlflow#6778) * Added padding to artifact text viewer Signed-off-by: Shraddha Falane <falane.shraddha18@gmail.com> * Modified padding for artifact text viewer Signed-off-by: Shraddha Falane <falane.shraddha18@gmail.com> Signed-off-by: Shraddha Falane <falane.shraddha18@gmail.com> Signed-off-by: Ivan Križanić <ikrizanic@croz.net> * Implemented `unwrap_python_model()` method in mlflow.pyfunc.PyFuncModel Signed-off-by: Ivan Križanić <ikrizanic@croz.net> * Simplified unwrap_python_model and added test for it Signed-off-by: Ivan Križanić <ikrizanic@croz.net> * Fixed lint and test errors Signed-off-by: Ivan Križanić <ikrizanic@croz.net> * Remove unused imports Signed-off-by: Ivan Križanić <ikrizanic@croz.net> * Update mlflow/pyfunc/__init__.py Co-authored-by: Ben Wilson <39283302+BenWilson2@users.noreply.github.com> Signed-off-by: Ivan Križanić <38288854+ikrizanic@users.noreply.github.com> Signed-off-by: Ivan Križanić <ikrizanic@croz.net> * reverted change in ShowArtifactTextView.js Signed-off-by: Ivan Križanić <ikrizanic@croz.net> * Optimized imports and reformated with black Signed-off-by: Ivan Križanić <ikrizanic@croz.net> Signed-off-by: Shraddha Falane <falane.shraddha18@gmail.com> Signed-off-by: Ivan Križanić <ikrizanic@croz.net> Signed-off-by: Ivan Križanić <38288854+ikrizanic@users.noreply.github.com> Co-authored-by: Shraddha Falane <72125392+shraddhafalane@users.noreply.github.com> Co-authored-by: Ivan Križanić <ikrizanic@croz.net> Co-authored-by: Ben Wilson <39283302+BenWilson2@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shraddha Falane falane.shraddha18@gmail.com
Related Issues/PRs
Closes #6757
What changes are proposed in this pull request?
(Please fill in changes proposed in this fix)
How is this patch tested?
Does this PR change the documentation?
Detailslink on thePreview docscheck.Release Notes
Is this a user-facing change?
(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts: Artifact stores and artifact loggingarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesarea/examples: Example codearea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models: MLmodel format, model serialization/deserialization, flavorsarea/pipelines: Pipelines, Pipeline APIs, Pipeline configs, Pipeline Templatesarea/projects: MLproject format, project running backendsarea/scoring: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra: MLflow Tracking server backendarea/tracking: Tracking Service, tracking client APIs, autologgingInterface
area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows: Windows supportLanguage
language/r: R APIs and clientslanguage/java: Java APIs and clientslanguage/new: Proposals for new client languagesIntegrations
integrations/azure: Azure and Azure ML integrationsintegrations/sagemaker: SageMaker integrationsintegrations/databricks: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notes