Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BERT-large details to the README #938

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add BERT-large details to the README #938

wants to merge 1 commit into from

Conversation

rnaidu02
Copy link
Contributor

Changed README to include bert-large and max-seq-length information in the table

@github-actions
Copy link

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@rnaidu02 rnaidu02 mentioned this pull request May 31, 2021
Closed
nvpohanh
nvpohanh approved these changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@nvpohanh nvpohanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheKanter
Copy link
Contributor

Thanks!

@guschmue
Copy link
Contributor

guschmue commented Jun 1, 2021

Can you merge with master. github complains you don't have a linear history.

@TheKanter
Copy link
Contributor

I don't seem to have the ability to do that from the web interface.

@kahmed10
Copy link
Contributor

@rnaidu02 while this PR still hasn't been merged, can you also fix a typo in https://github.com/mlcommons/inference/blob/master/language/bert/README.md?

The inputs to the SUT are input_ids, input_make, and segment_ids. The output from SUT is start_logits and end_logits concatenated together.
Should be input_mask, not input_make

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvpohanh nvpohanh nvpohanh approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rnaidu02 @TheKanter @guschmue @kahmed10 @nvpohanh