[Testing] Add unit tests for Gemma3 model #3362
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds comprehensive unit tests for the Gemma3 model architecture, which was added in mlc-ai#3172, mlc-ai#3178, mlc-ai#3224 but lacked test coverage. Changes: - Add tests/python/model/test_gemma3.py with the following test cases: * test_gemma3_model_registered: Verify model is in registry * test_gemma3_creation: Test model creation and TVM export * test_gemma3_config_validation: Validate configuration parameters - Tests cover gemma3_2b and gemma3_9b variants - Follows pattern from test_llama.py Testing: All tests pass locally (instructions in PR description for reproduction) Part of effort to add test coverage for recently added models.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive unit tests for the Gemma3 model architecture, which was added in #3172, #3178, #3224 but lacked test coverage.
Changes
tests/python/model/test_gemma3.pywith test cases:test_gemma3_model_registered: Verify model is in registrytest_gemma3_creation: Test model creation and TVM export (gemma3_2b, gemma3_9b)test_gemma3_config_validation: Validate configuration parameterstest_llama.pyTesting
To run tests locally:
Part of
Adding test coverage for recently added models (Gemma3, Qwen3, Phi-4, Llama4).