Merge pull request #5 from mkwng-org/block-mythical-oneofone-updates

Block user from adding features only available through random mints

Author: mkwng

data/helpers.test.ts

@@ -129,4 +129,103 @@ describe("getDifferences", () => {
       }
     ])
   });
+  it("calculates mythic and oneofone costs properly", async () => {
+    let newCompanion = JSON.parse(JSON.stringify(oldCompanion));
+    newCompanion.attributes.top.name = "tattooshirt";
+    newCompanion.attributes.headwear = {
+      name: "hijab",
+      color: [
+        {
+          "r": 163,
+          "g": 192,
+          "b": 191
+        }
+      ]
+    }
+    let differences = getDifferences(oldCompanion, newCompanion)
+    expect(differences).toEqual([
+      {
+        cost: 500000,
+        prev: 'earphones',
+        curr: 'hijab',
+        key: 'headwear',
+        type: 'attribute'
+      },
+      {
+        "cost": 250,
+        "curr": "lightblue",
+        "key": "headwearColor1",
+        "prev": "",
+        "type": "color",
+      },
+      {
+        cost: 500000,
+        prev: 'buttonup',
+        curr: 'tattooshirt',
+        key: 'top',
+        type: 'attribute'
+      },
+      {
+        cost: 0,
+        prev: 'lightblue',
+        curr: '',
+        key: 'topColor1',
+        type: 'color'
+      }
+    ])
+  });
+
+  it("calculates pose costs correctly", async () => {
+    let newCompanion = JSON.parse(JSON.stringify(oldCompanion));
+    newCompanion.properties.pose = 3;
+
+    let differences = getDifferences(oldCompanion, newCompanion)
+    expect(differences).toEqual(
+      [{
+        "cost": 500,
+        "curr": 3,
+        "key": "pose",
+        "prev": 2,
+        "type": "property"
+      }])
+
+    newCompanion.properties.pose = 4;
+
+    differences = getDifferences(oldCompanion, newCompanion)
+    expect(differences).toEqual(
+      [{
+        "cost": 500000,
+        "curr": 4,
+        "key": "pose",
+        "prev": 2,
+        "type": "property"
+      }])
+  });
+
+  it("calculates gender costs correctly", async () => {
+    let newCompanion = JSON.parse(JSON.stringify(oldCompanion));
+    newCompanion.properties.gender = "f";
+
+    let differences = getDifferences(oldCompanion, newCompanion)
+    expect(differences).toEqual(
+      [{
+        "cost": 500,
+        "curr": "f",
+        "key": "gender",
+        "prev": "m",
+        "type": "property"
+      }])
+
+    newCompanion.properties.gender = "w";
+
+    differences = getDifferences(oldCompanion, newCompanion)
+    expect(differences).toEqual(
+      [{
+        "cost": 500000,
+        "curr": "w",
+        "key": "gender",
+        "prev": "m",
+        "type": "property"
+      }])
+  });
 })

data/helpers.ts

@@ -6,15 +6,18 @@ import {
 	AttributeSelection,
 	AttributeType,
 	Companion,
+	GenderValue,
 	Layer,
 	LayerStaticWithData,
 	LayerWithData,
 	Pose,
+	Property,
 	Rarity,
 	Restrictions,
 	RGBColor,
 	Variant,
 } from "./types";
+// @ts-ignore -- .prisma/client is only generated after running migrations
 import { Companion as PrismaCompanion } from ".prisma/client";
 import _ from "lodash";
 
@@ -629,15 +632,24 @@ export const rarityToCost = {
 	common: 1000,
 	uncommon: 5000,
 	rare: 10000,
-	mythic: 20000,
+	// It should not be possible to buy mythics or oneofone items
+	mythic: 500000,
+	oneofone: 500000,
 };
 
 const getKeyCost = (key: string, value: string) => {
 	switch (getKeyType(key)) {
 		case "name":
 			return 1;
 		case "property":
-			return 500;
+			switch (key) {
+				case Property.Pose:
+					return parseInt(value) === Pose.Headdown ? rarityToCost.mythic : 500;
+				case Property.Gender:
+					return value === GenderValue.W ? rarityToCost.mythic : 500;
+				default:
+					return 500;
+			}
 		case "color":
 			return 250;
 		case "attribute":

data/types.ts

@@ -19,6 +19,16 @@ export enum Pose {
 	Headdown,
 }
 
+export enum Property {
+	Gender = "gender",
+	Pose = "pose",
+	Skin = "skin",
+	Hair = "hair",
+	Background = "background"
+}
+
+export type PropertyType = `${Property}`
+
 export type AttributeType =
 	| "background"
 	| "bodyBack"
@@ -41,7 +51,13 @@ export type AttributeType =
 	| "shoes"
 	| "accessory";
 
-type Gender = "m" | "f" | "w";
+// TODO:: GenderValue is named inconsistently for now because we have to rename Gender to GenderType
+export enum GenderValue {
+	M = "m",
+	F = "f",
+	W = "w"
+}
+type Gender = `${GenderValue}`;
 type HeadShape = "big" | "flat";
 type ProfileShape = "flat" | "encroached";
 export type Rarity = "common" | "uncommon" | "rare" | "mythic" | "oneofone";

pages/api/companion/[id].ts

@@ -2,7 +2,7 @@ import { Companion as PrismaCompanion } from ".prisma/client";
 import { NextApiRequest, NextApiResponse } from "next";
 import { ownerAddress } from "../../../components/contract";
 import { colors, rgbToHex } from "../../../data/colors";
-import { apiToKeys, getDifferences, keysToCompanion, messageToSign, zeroPad } from "../../../data/helpers";
+import { apiToKeys, getDifferences, keysToCompanion, messageToSign, rarityToCost, zeroPad } from "../../../data/helpers";
 import { updateCompanion } from "../../../data/operations";
 import { randomCompanion } from "../../../data/random";
 import { Companion } from "../../../data/types";
@@ -122,10 +122,18 @@ export default async function apiCompanions(req: NextApiRequest, res: NextApiRes
 							where: { tokenId: parseInt(tokenId) },
 						})
 					);
+
 					const uneditedCompanion =  keysToCompanion(apiToKeys(prismaResponse));
 					const differences = getDifferences(uneditedCompanion, companion);
-					const balance = coupon ? 0 : differences.reduce((acc, cur) => acc + cur.cost, 0);
+					const costOfChanges = differences.reduce((acc, cur) => acc + cur.cost, 0);
+					// It should be impossible to have changes that cost more than a mythic unless someone added a mythic
+					if (costOfChanges >= rarityToCost.mythic) {
+						throw new Error("Invalid items were added to companion");
+					} else if (costOfChanges === 0) {
+						throw new Error("Companion has no changes!");
+					}
 
+					const balance = coupon ? 0 : costOfChanges;
 					if (balance > 0) {
 						let hashUsed;
 						try {