Migrate to non-deprecated MediaWiki API

Author: mmarx

src/AutoCreatePage.php

@@ -2,14 +2,16 @@
 
 namespace ACP;
 
-use ContentHandler;
+use CommentStoreComment;
 use MediaWiki\Hook\ParserFirstCallInitHook;
+use MediaWiki\MediaWikiServices;
+use MediaWiki\Revision\SlotRecord;
 use MediaWiki\SpecialPage\Hook\SpecialPageAfterExecuteHook;
 use MediaWiki\SpecialPage\Hook\SpecialPageBeforeExecuteHook;
 use MediaWiki\Storage\Hook\RevisionDataUpdatesHook;
 use Parser;
 use Title;
-use WikiPage;
+use WikitextContent;
 
 /**
  * This extension provides a parser function #createpageifnotex that can be used to create
@@ -77,19 +79,23 @@ public static function createPageIfNotExisting( $parser, $newPageTitleText, $new
 
 		// Get the raw text of $newPageContent as it was before stripping <nowiki>:
 		$newPageContent = $parser->getStripState()->unstripNoWiki( $newPageContent );
+		$newPageData = [
+			"content" => $newPageContent,
+			"user" => $parser->getUserIdentity()
+		];
 
 		$enabledSpecialPage = self::enabledSpecialPage();
 		if ( $enabledSpecialPage ) {
 			// Store data in static variable for later use in onSpecialPageAfterExecute:
-			$enabledSpecialPage->addPageToCreate( $newPageTitleText, $newPageContent );
+			$enabledSpecialPage->addPageToCreate( $newPageTitleText, $newPageData );
 		} elseif ( in_array( $parser->getTitle()->getNamespace(), $autoCreatePageNamespaces ) ) {
 			// For pages with namespace in $autoCreatePageNamespaces store data in the parser output
 			// for later use in onRevisionDataUpdates:s
 			$createPageData = $parser->getOutput()->getExtensionData( 'createPage' );
 			if ( $createPageData === null ) {
 				$createPageData = [];
 			}
-			$createPageData[$newPageTitleText] = $newPageContent;
+			$createPageData[$newPageTitleText] = $newPageData;
 			$parser->getOutput()->setExtensionData( 'createPage', $createPageData );
 		}
 
@@ -114,8 +120,8 @@ public function onRevisionDataUpdates( $title, $renderedRevision, &$updates ) {
 		// Prevent pages to be created by pages that are created to avoid loops:
 		$egAutoCreatePageMaxRecursion--;
 
-		foreach ( $createPageData as $pageTitleText => $pageContentText ) {
-			self::createPage( $title, $pageTitleText, $pageContentText );
+		foreach ( $createPageData as $pageTitleText => $pageContentData ) {
+			self::createPage( $title, $pageTitleText, $pageContentData );
 		}
 
 		// Reset state. Probably not needed since parsing is usually done here anyway:
@@ -142,8 +148,8 @@ public function onSpecialPageAfterExecute( $special, $subPage ) {
 		$specialPage = array_pop( self::$specialPageStack );
 
 		if ( $specialPage->isEnabled() ) {
-			foreach ( $specialPage->pagesToCreate() as $pageTitleText => $pageContentText ) {
-				self::createPage( $special->getFullTitle(), $pageTitleText, $pageContentText );
+			foreach ( $specialPage->pagesToCreate() as $pageTitleText => $pageContentData ) {
+				self::createPage( $special->getFullTitle(), $pageTitleText, $pageContentData );
 			}
 		}
 	}
@@ -157,16 +163,23 @@ private static function enabledSpecialPage() {
 		return $currentSpecialPage !== null && $currentSpecialPage->isEnabled() ? $currentSpecialPage : null;
 	}
 
-	private static function createPage( $sourceTitle, $pageTitleText, $pageContentText ) {
+	private static function createPage( $sourceTitle, $pageTitleText, $pageContentData ) {
+		$pageContentText = new WikitextContent( $pageContentData["content"] );
+		$author = $pageContentData["user"];
 		$sourceTitleText = $sourceTitle->getPrefixedText();
 		$pageTitle = Title::newFromText( $pageTitleText );
 		// wfDebugLog( 'createpage', "CREATE " . $pageTitle->getText() . " Text: " . $pageContent );
 
 		if ( $pageTitle !== null && !$pageTitle->isKnown() && $pageTitle->canExist() ) {
-			$newWikiPage = new WikiPage( $pageTitle );
-			$pageContent = ContentHandler::makeContent( $pageContentText, $sourceTitle );
-			$newWikiPage->doEditContent( $pageContent,
-				"Page created automatically by parser function on page [[$sourceTitleText]]" ); // TODO i18n
+			$page = $pageTitle->toPageIdentity();
+			$comment = CommentStoreComment::newUnsavedComment(
+				"Page created automatically by parser function on page [[$sourceTitleText]]" // TODO i18n
+			);
+			$factory = MediaWikiServices::getInstance()->getPageUpdaterFactory();
+			$updater = $factory->newPageUpdater( $page, $author );
+			$updater->setContent( SlotRecord::MAIN, $pageContentText );
+			$updater->saveRevision( $comment );
+
 			// wfDebugLog( 'createpage', "CREATED PAGE " . $pageTitle->getText() . " Text: " . $pageContent );
 		}
 	}

src/SpecialPage.php

@@ -15,8 +15,8 @@ public function isEnabled() {
 		return $this->isEnabled;
 	}
 
-	public function addPageToCreate( $titleText, $content ) {
-		$this->pagesToCreate[$titleText] = $content;
+	public function addPageToCreate( $titleText, $data ) {
+		$this->pagesToCreate[$titleText] = $data;
 	}
 
 	public function pagesToCreate() {