limited base filename to 230 bytes to be able to download audiobooks with long filenames. #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 14, 2024 13:12
- added filename-mode option: asin_only
devvythelopper
changed the title
mkb79
reviewed
Dec 14, 2024
Refactored the `create_base_filename` method to streamline mode handling and added a `max_length` parameter for truncation. Removed redundant encoding logic and ensured compatibility with all supported modes, improving code clarity and maintainability.
This change ensures filename length is restricted by bytes rather than characters, addressing potential issues with UTF-8 encoded characters that may span multiple bytes. Filesystem compatibility is improved and truncation behavior is adjusted to avoid errors with multi-byte characters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a fix for #215
also added filename-mode option: asin_only