-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download by series, download by author #184
base: master
Are you sure you want to change the base?
Conversation
It looks quite good so far. One point should be considered again. What if someone is looking for a title and author. Then only audio books should be displayed where the title and author match. Currently, he would search by title or author and add the results! |
That is true; I assumed that was the way you wanted to do it since that's how it's set up with ASNs and titles, but if you want I can probably figure out how to do an intersection instead |
Maybe the |
help="title of the audiobook (partial search)" | ||
) | ||
@click.option( | ||
"--author", "-a", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The -a
option is already used by --asin
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops =] I thought I'd looked for that.
All things considered, I think the more natural assumption would be to have the different lists merged before checking -- I just haven't had time to come back to this since then and I'm not sure how soon I can
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'll have time this weekend to rework some things and then merge your request.
Implements #183
My python is more than a bit rusty; I tried to follow existing patterns, but let me know if there is anything you need me to fix.