Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A question about compile v2/v3/v4 source code #301

Open
RainSureZhao opened this issue Jul 24, 2024 · 4 comments
Open

A question about compile v2/v3/v4 source code #301

RainSureZhao opened this issue Jul 24, 2024 · 4 comments

Comments

@RainSureZhao
Copy link

RainSureZhao commented Jul 24, 2024

Hello, when I try to compile the source code for version v2/v3/v4 using the Makefile, I use make all/make release, but I am told that AddTriangles() is not found.

The error message is here:

In file included from Src/MultiGridOctreeData.h:254,
                 from Src/MultiGridOctest.cpp:86:
Src/MultiGridOctreeData.inl: In static member function 'static int Octree<Degree>::AddTriangles(CoredMeshData*, std::vector<CoredPointIndex>*, std::vector<Point3D<float> >*, const int&)':
Src/MultiGridOctreeData.inl:2279:53: error: no matching function for call to 'Octree<Degree>::AddTriangles(CoredMeshData*&, std::vector<CoredPointIndex>&, std::vector<Point3D<float> >*&, const int&)'
  return AddTriangles(mesh,e,interiorPositions,offSet);

Compilation environment:
ubuntu 22.04
GNU Make 4.3
g++ 11.4.0

@mkazhdan
Copy link
Owner

It's been a while since I've looked at those versions.
Just out of curiosity, is there a reason you're not using a newer version?

@RainSureZhao
Copy link
Author

It's been a while since I've looked at those versions. Just out of curiosity, is there a reason you're not using a newer version?

Because I am reading the original paper in 2006, I want to cooperate with the code reading so that the understanding will be deeper. Now I have learned the code of V1 version, and I want to know what upgrades and changes have been made in V2, V3, V4 and other versions, so I tried to compile it, but something went wrong, and the code of V1 version will not report errors. So I want to know why.

@mkazhdan
Copy link
Owner

I have updated the source code in Version2/3/4.
It should now compile using the Makefile.
(I also added a Makefile to Version4.)

Note that as I was developing on a machine without OpenMP, I disabled the parallelization calls in Version4.

@RainSureZhao
Copy link
Author

I have updated the source code in Version2/3/4. It should now compile using the Makefile. (I also added a Makefile to Version4.)

Note that as I was developing on a machine without OpenMP, I disabled the parallelization calls in Version4.

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants