Merge pull request mavlink#370 from qthibeault/main

Replace print statements with logging statements

Author: JonasVautherin

mavsdk/async_plugin_manager.py

@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+import logging
 import aiogrpc
 
 
@@ -29,9 +30,12 @@ async def _connect_backend(self):
             "{}:{}".format(self.host, self.port)
         )
 
-        print("Waiting for mavsdk_server to be ready...")
+        logger = logging.getLogger(__name__)
+        logger.addHandler(logging.NullHandler())  # Avoid errors when user has not configured logging
+
+        logger.debug("Waiting for mavsdk_server to be ready...")
         await aiogrpc.channel_ready_future(self._channel)
-        print("Connected to mavsdk_server!")
+        logger.debug("Connected to mavsdk_server!")
 
     @property
     def channel(self):

mavsdk/system.py

@@ -1,5 +1,8 @@
 # -*- coding: utf-8 -*-
 
+import logging
+import threading
+
 from .async_plugin_manager import AsyncPluginManager
 
 from . import action
@@ -28,6 +31,16 @@
 from . import bin
 
 
+class _LoggingThread(threading.Thread):
+    def __init__(self, pipe, log_fn):
+        super().__init__()
+        self.pipe = pipe
+        self.log_fn = log_fn
+
+    def run(self):
+        for line in self.pipe:
+            self.log_fn(line.decode("utf-8").replace("\n", ""))
+
 class System:
     """
     Instantiate a System object, that will serve as a proxy to
@@ -281,8 +294,12 @@ def _start_mavsdk_server(system_address=None,port=50051):
                     bin_path_and_args.append(system_address)
                 p = subprocess.Popen(bin_path_and_args,
                                      shell=False,
-                                     stdout=subprocess.DEVNULL,
-                                     stderr=subprocess.DEVNULL)
+                                     stdout=subprocess.PIPE,
+                                     stderr=subprocess.STDOUT)
+
+                logger = logging.getLogger(__name__)
+                log_thread = _LoggingThread(p.stdout, logger.debug)
+                log_thread.start()
         except FileNotFoundError:
             print("""
 This installation does not provide an embedded 'mavsdk_server' binary.