-
Notifications
You must be signed in to change notification settings - Fork 962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handlebars tag support (used by mandrill) #42
Comments
That's a point, but allowing multiple template languages would be heavy right? Maybe we could implement a preprocessor in another repo like |
In my opinion, the role of MJML is to render a responsive HTML email layout. That said, for your use-case, I would recommend to wrap all the handlebars templating tags with an Once you have the HTML code, you can pass it to handlebar, with the right execution context so it outputs an HTML ready to be sent. Does it make sense to you? Hope I haven't missed something here! Let us know how that works for you! |
Would it be necessary to wrap those handlebar tags in |
@fabien, yes, for now it is a known limitation of our engine. Because of the way we parse the DOM, we need a tag to wrap even basic text/HTML element/tags. This is actually the main reason why we needed to introduce such tag. That said, this is obviously something we're aiming to improve in a near future. Keep you posted on our progress here! |
Hey @romainyakarouler, did my comment help you moving forward on your issue? Thanks! |
@arnaudbreton would be nice to have an example for the mj-raw to wow the users right away. currently the documentation seems very minimal |
Also worth noting that |
preprocessors can handle this now https://thoughtbot.com/blog/building-templated-emails-with-mjml though the vscode extension is not supporting this style yet. I've added a PR to address this, but in the meantime have published a forked version with that feature enabled: https://marketplace.visualstudio.com/items?itemName=IvanKeirn.vscode-mjml-custom-path |
Hello,
Mandrill and Mailchimp support Handlebars template syntax, could we imagine a command like
mjml -r template.mjml -o template.html --syntax=handlebars
ormjml -r template.mjml -o template.html --syntax=mailchimp
?Example:
Links:
Thank u, Mjml is great!
The text was updated successfully, but these errors were encountered: