Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @viewport declaration in viewport styles #1618

Closed
hteumeuleu opened this issue Jun 17, 2019 · 2 comments
Closed

Remove @viewport declaration in viewport styles #1618

hteumeuleu opened this issue Jun 17, 2019 · 2 comments

Comments

@hteumeuleu
Copy link

hteumeuleu commented Jun 17, 2019

In the default styles generated by MJML, we have the following block:

<!--[if !mso]><!-->
  <style type="text/css">
    @media only screen and (max-width:480px) {
      @-ms-viewport {
        width: 320px;
      }
      @viewport {
        width: 320px;
      }
    }
  </style>
  <!--<![endif]-->

This was useful to trigger a mobile viewport width on the default email client in Windows Phone 8. This was never used in any other email client as far as I know. Considering Windows Phone 8 is dead, it probably should be a good idea to remove this. Or maybe if some people are still finding this useful, have this only generated when using a special "legacy" option to generate HTML?

Here's an article (in french) about Windows Phone 8 and @viewport declaration.

@steveocarr
Copy link

This would resolve #844 as well

@Pharmasolin
Copy link
Contributor

@hteumeuleu is right, I also remove this part from output file. It would be great to have at least CLI option something like --no-windows-phone-support which will remove this part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants