mj-include - allow absolute paths

[araphiel]

Ideal behavior

File: archive/index.mjml

• <mj-include root="true" path="/partials/footer.mjml" />

Command: npx mjml ./archive/**/*.mjml -o ./dist

• ✅ All files in located in a the archive will compile into the /dist folder
• 🚫 mj-include partials are referenced from project root directory, instead of file directory.

---

Why?: This would allow larger teams to provide a consistent workspace + archive

├── index.mjml // working file (untracked)
├── partials // template partials
|    ├── header.mjml
|    └── footer.mjml
└── archive // repo of old work
    └── events
    |   └── event-email-96.mjml
    └── newletters
        ├── newsletter-55.mjml
        └── random-campaign
            └── campaign-newsletter.mjml

[araphiel]

As it turns out, this functionality exist via the mjml2html options .

I do think the filePath option would be really useful if exposed via CLI.

It's basic but this was a work around for me.

const { readFile, writeFile } = require('fs')
const { parse, resolve } = require('path')
const recursive = require("recursive-readdir")
const mjml2html = require("mjml")


recursive('archive', (err, files) => {
    files.forEach((file, index) => {

        const { name } = parse(file)

        readFile(file, 'utf-8', (err, data) => {
            if (err) throw err;

            const options = {
                beautify: true, 
                filePath: resolve('partials'),
                minify: true,
            }

            const { html } = mjml2html(data, options)

            writeFile(`dist/${name}.html`, html, 'utf-8', err => {
                if (err) throw err
            })
        })
    })
})

[kmcb777]

@araphiel actually all the mjml2html options can be used with the cli with --config, so you can already do --config.filePath ./includes
We'll add this one to the cli documentation 👍

[araphiel]

Thanks for reaching out @kmcb777

Just tested it out (using the command below) & the mj-include partials didn't compile.

npx mjml archive/general/webinar_thank-you.mjml --config.filePath ./partials -o index.html

Maybe filePath needs to be explictly exposed via the CLI?

mjml/packages/mjml-cli/src/client.js

Line 100 in da9825c

const config = Object.assign(DEFAULT_OPTIONS, argv.c, fonts && {fonts}, minifyOptions && {minifyOptions})

mjml/packages/mjml-cli/src/client.js

Line 175 in da9825c

compiled = mjml2html(i.mjml, { ...config, filePath: i.file })

[iRyusa]

You have to use relative path no absolute

…

On 22 Mar 2019, at 06:43, Armon Raphiel ***@***.***> wrote: Thanks for reaching out @kmcb777 Just tested it out (using the command below) & the mj-include partials didn't compile. npx mjml archive/general/webinar_thank-you.mjml --config.filePath ./partials -o index.html Maybe filePath needs to be explictly exposed via the CLI? https://github.com/mjmlio/mjml/blob/da9825c1628aa4259feddb4bf5ccbcb5fa338b10/packages/mjml-cli/src/client.js#L100 https://github.com/mjmlio/mjml/blob/da9825c1628aa4259feddb4bf5ccbcb5fa338b10/packages/mjml-cli/src/client.js#L175 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.