Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time stamp to messages #157

Open
krunoPeric opened this issue Jun 20, 2020 · 6 comments
Open

Add time stamp to messages #157

krunoPeric opened this issue Jun 20, 2020 · 6 comments

Comments

@krunoPeric
Copy link

Summary

It would be great if each message was preceded by a time stamp!

Motivation

Sometimes you want to look back to the date and time of the message.

@tomquirk tomquirk changed the title Time Stamp Add time stamp to messages Jun 21, 2020
@michondr
Copy link

+1.

this is great feature, would be great to enable/dissable in options

@Ravichandra-C
Copy link
Contributor

Ravichandra-C commented Nov 19, 2020

Hi All,

I would like to work on this.

Question Regarding the feature

@krunoPeric @michondr @tomquirk

Should I just add timestamp to the messages shown in history command?

Will this format be good?

[Date,Timestamp] User name:Message

for example

[11/17/2020, 4:29:30 PM] Ravichandra:Hi

Is it Ok, if the date and time format is the format returned by toLocaleString() ?

@michondr
Copy link

toLocaleString should return output most suitable for the user. if you want to make it fancier, you could enable the user to set the format himself

@Ravichandra-C
Copy link
Contributor

Can I send the pull request with toLocaleString?

@tomquirk
Copy link
Collaborator

Yep, this looks great @Ravichandra-C.

@Ravichandra-C
Copy link
Contributor

Ravichandra-C commented Nov 21, 2020

Added this feature as part of #165 pull request.
@tomquirk @mjkaufer
Can you please merge it if the changes looks good? If not, Can you please let me know what else needs to be done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants