Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to select specific changlelist on file operations #185

Open
evg656e opened this issue Sep 16, 2020 · 3 comments
Open

Allow to select specific changlelist on file operations #185

evg656e opened this issue Sep 16, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@evg656e
Copy link

evg656e commented Sep 16, 2020

If there is more than one changelist in the workspace, allow to select the desired changelist, like it is done in p4v.

select_pending_changelist

@mjcrouch mjcrouch added the enhancement New feature or request label Sep 16, 2020
@mjcrouch
Copy link
Owner

Hi,

Thanks for the suggestion, this is something I've thought about previously.

I think choosing the changelist as you perform the action might be a little difficult to implement in a consistent way that a user would understand. For example if you have the extension set to automatically open a file every time you edit it, then we would have to either prompt the user on every save or just always open in the default changelist on save, which is not very consistent. That's not to rule this approach out - It might not be as confusing as I think.

IIRC the jetbrains perforce plugin and maybe eclipse or visual studio plugins have something like a "target" changelist that you choose in advance, so whenever you open or add a file it puts it in to that changelist by default. This might be easier to implement but I think it is still challenging to come up with a consistent behaviour that works without weird errors. - particularly if you also use an external perforce client to perform actions (e.g. your target changelist might be submitted externally).

So to summarise, I think it could be a useful addition, but needs some careful thought and may take some time to implement

@evg656e
Copy link
Author

evg656e commented Sep 16, 2020

For example if you have the extension set to automatically open a file every time you edit it, then we would have to either prompt the user on every save or just always open in the default changelist on save, which is not very consistent.

imo it would be fine to show prompt only when file editing is invoked from vs menu (otherwise files should go into default changelist, at least this is how the official client works).

IIRC the jetbrains perforce plugin and maybe eclipse or visual studio plugins have something like a "target" changelist that you choose in advance, so whenever you open or add a file it puts it in to that changelist by default

it's a good option too (at least in case when you mainly work with one changelist in a time)

@sandipchitale
Copy link

+1

If we can mark a specific change list/workspace folder, as target change list, that will be great. I may submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants