Skip to content

Commit d8d0a1b

Browse files
gokulkumar-ifxgregkh
authored andcommitted
wifi: brcmfmac: fix 43752 SDIO FWVID incorrectly labelled as Cypress (CYW)
[ Upstream commit 74e2ef7 ] Cypress(Infineon) is not the vendor for this 43752 SDIO WLAN chip, and so has not officially released any firmware binary for it. It is incorrect to maintain this WLAN chip with firmware vendor ID as "CYW". So relabel the chip's firmware Vendor ID as "WCC" as suggested by the maintainer. Fixes: d2587c5 ("brcmfmac: add 43752 SDIO ids and initialization") Fixes: f74f1ec ("wifi: brcmfmac: add support for Cypress firmware api") Signed-off-by: Gokul Sivakumar <gokulkumar.sivakumar@infineon.com> Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com> Link: https://patch.msgid.link/20250724101136.6691-1-gokulkumar.sivakumar@infineon.com Signed-off-by: Johannes Berg <johannes.berg@intel.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 1504b08 commit d8d0a1b

File tree

5 files changed

+8
-9
lines changed

5 files changed

+8
-9
lines changed

drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -997,9 +997,9 @@ static const struct sdio_device_id brcmf_sdmmc_ids[] = {
997997
BRCMF_SDIO_DEVICE(SDIO_DEVICE_ID_BROADCOM_4356, WCC),
998998
BRCMF_SDIO_DEVICE(SDIO_DEVICE_ID_BROADCOM_4359, WCC),
999999
BRCMF_SDIO_DEVICE(SDIO_DEVICE_ID_BROADCOM_43751, WCC),
1000+
BRCMF_SDIO_DEVICE(SDIO_DEVICE_ID_BROADCOM_43752, WCC),
10001001
BRCMF_SDIO_DEVICE(SDIO_DEVICE_ID_BROADCOM_CYPRESS_4373, CYW),
10011002
BRCMF_SDIO_DEVICE(SDIO_DEVICE_ID_BROADCOM_CYPRESS_43012, CYW),
1002-
BRCMF_SDIO_DEVICE(SDIO_DEVICE_ID_BROADCOM_CYPRESS_43752, CYW),
10031003
BRCMF_SDIO_DEVICE(SDIO_DEVICE_ID_BROADCOM_CYPRESS_89359, CYW),
10041004
CYW_SDIO_DEVICE(SDIO_DEVICE_ID_BROADCOM_CYPRESS_43439, CYW),
10051005
{ /* end: all zeroes */ }

drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -738,8 +738,8 @@ static u32 brcmf_chip_tcm_rambase(struct brcmf_chip_priv *ci)
738738
case BRCM_CC_4364_CHIP_ID:
739739
case CY_CC_4373_CHIP_ID:
740740
return 0x160000;
741-
case CY_CC_43752_CHIP_ID:
742741
case BRCM_CC_43751_CHIP_ID:
742+
case BRCM_CC_43752_CHIP_ID:
743743
case BRCM_CC_4377_CHIP_ID:
744744
return 0x170000;
745745
case BRCM_CC_4378_CHIP_ID:
@@ -1452,7 +1452,7 @@ bool brcmf_chip_sr_capable(struct brcmf_chip *pub)
14521452
return (reg & CC_SR_CTL0_ENABLE_MASK) != 0;
14531453
case BRCM_CC_4359_CHIP_ID:
14541454
case BRCM_CC_43751_CHIP_ID:
1455-
case CY_CC_43752_CHIP_ID:
1455+
case BRCM_CC_43752_CHIP_ID:
14561456
case CY_CC_43012_CHIP_ID:
14571457
addr = CORE_CC_REG(pmu->base, retention_ctl);
14581458
reg = chip->ops->read32(chip->ctx, addr);

drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -655,10 +655,10 @@ static const struct brcmf_firmware_mapping brcmf_sdio_fwnames[] = {
655655
BRCMF_FW_ENTRY(BRCM_CC_4356_CHIP_ID, 0xFFFFFFFF, 4356),
656656
BRCMF_FW_ENTRY(BRCM_CC_4359_CHIP_ID, 0xFFFFFFFF, 4359),
657657
BRCMF_FW_ENTRY(BRCM_CC_43751_CHIP_ID, 0xFFFFFFFF, 43752),
658+
BRCMF_FW_ENTRY(BRCM_CC_43752_CHIP_ID, 0xFFFFFFFF, 43752),
658659
BRCMF_FW_ENTRY(CY_CC_4373_CHIP_ID, 0xFFFFFFFF, 4373),
659660
BRCMF_FW_ENTRY(CY_CC_43012_CHIP_ID, 0xFFFFFFFF, 43012),
660661
BRCMF_FW_ENTRY(CY_CC_43439_CHIP_ID, 0xFFFFFFFF, 43439),
661-
BRCMF_FW_ENTRY(CY_CC_43752_CHIP_ID, 0xFFFFFFFF, 43752)
662662
};
663663

664664
#define TXCTL_CREDITS 2
@@ -3426,8 +3426,8 @@ static int brcmf_sdio_download_firmware(struct brcmf_sdio *bus,
34263426
static bool brcmf_sdio_aos_no_decode(struct brcmf_sdio *bus)
34273427
{
34283428
if (bus->ci->chip == BRCM_CC_43751_CHIP_ID ||
3429-
bus->ci->chip == CY_CC_43012_CHIP_ID ||
3430-
bus->ci->chip == CY_CC_43752_CHIP_ID)
3429+
bus->ci->chip == BRCM_CC_43752_CHIP_ID ||
3430+
bus->ci->chip == CY_CC_43012_CHIP_ID)
34313431
return true;
34323432
else
34333433
return false;
@@ -4278,8 +4278,8 @@ static void brcmf_sdio_firmware_callback(struct device *dev, int err,
42784278

42794279
switch (sdiod->func1->device) {
42804280
case SDIO_DEVICE_ID_BROADCOM_43751:
4281+
case SDIO_DEVICE_ID_BROADCOM_43752:
42814282
case SDIO_DEVICE_ID_BROADCOM_CYPRESS_4373:
4282-
case SDIO_DEVICE_ID_BROADCOM_CYPRESS_43752:
42834283
brcmf_dbg(INFO, "set F2 watermark to 0x%x*4 bytes\n",
42844284
CY_4373_F2_WATERMARK);
42854285
brcmf_sdiod_writeb(sdiod, SBSDIO_WATERMARK,

drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@
6060
#define CY_CC_4373_CHIP_ID 0x4373
6161
#define CY_CC_43012_CHIP_ID 43012
6262
#define CY_CC_43439_CHIP_ID 43439
63-
#define CY_CC_43752_CHIP_ID 43752
6463

6564
/* USB Device IDs */
6665
#define BRCM_USB_43143_DEVICE_ID 0xbd1e

include/linux/mmc/sdio_ids.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@
7777
#define SDIO_DEVICE_ID_BROADCOM_43439 0xa9af
7878
#define SDIO_DEVICE_ID_BROADCOM_43455 0xa9bf
7979
#define SDIO_DEVICE_ID_BROADCOM_43751 0xaae7
80-
#define SDIO_DEVICE_ID_BROADCOM_CYPRESS_43752 0xaae8
80+
#define SDIO_DEVICE_ID_BROADCOM_43752 0xaae8
8181

8282
#define SDIO_VENDOR_ID_CYPRESS 0x04b4
8383
#define SDIO_DEVICE_ID_BROADCOM_CYPRESS_43439 0xbd3d

0 commit comments

Comments
 (0)