Merge pull request wolfSSL#7805 from julek-wolfssl/wolfSSL_X509_REQ_a…

…dd1_attr_by_NID-push-cleanup wolfSSL_X509_REQ_add1_attr_by_NID: clean up push call for analyzers
miyazakh · Jul 31, 2024 · 5499783 · 5499783
2 parents 1ade735 + 2d5462d
commit 5499783
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/x509.c b/src/x509.c
@@ -14510,11 +14510,12 @@ int wolfSSL_X509_REQ_add1_attr_by_NID(WOLFSSL_X509 *req,
                 req->reqAttributes->type = STACK_TYPE_X509_REQ_ATTR;
             }
         }
-        ret = wolfSSL_sk_push(req->reqAttributes, attr);
-        if ((ret != WOLFSSL_SUCCESS) || (req->reqAttributes->type == STACK_TYPE_CIPHER)) {
-            /* CIPHER type makes a copy */
+        if (req->reqAttributes->type == STACK_TYPE_X509_REQ_ATTR)
+            ret = wolfSSL_sk_push(req->reqAttributes, attr);
+        else
+            ret = WOLFSSL_FAILURE;
+        if (ret != WOLFSSL_SUCCESS)
             wolfSSL_X509_ATTRIBUTE_free(attr);
-        }
     }
 
     return ret;