test: Only register SoundSourceProviders when actually necessary #3974
Conversation
src/test/soundsourcemixin.h
Outdated
| #pragma once | ||
| #include "sources/soundsourceproxy.h" | ||
|
|
||
| class SoundSourceMixin { |
There was a problem hiding this comment.
How about naming it SoundSourceProviderRegistration? With a doc comment stating that this class is supposed to be used as a mixin for test classes that require accessing SoundSources.
There was a problem hiding this comment.
SoundSourceProviderRegistrationMixin?
There was a problem hiding this comment.
However. It does not need to be used strictly as a mixin. You could also instantiate the class a simple member.
There was a problem hiding this comment.
It's just the RAII pattern. You only need to use it as mixin if the constructor must run before another base class. But this depends on the usage context and is not an inherent restriction of the class as such.
This allows tests to inherit from MixxxTest and still register SoundSourceProviders themselves, e.g. by instantiating CoreServices. It also reduces log spam caused by the sound source provider registration.
Holzhaus
force-pushed
the
soundsourcemixin
branch
from
d2e5a99 to
c7d8e8b
Compare
|
Thanks. Speedup is negligible, but the reduced log spam is worth it. |
This allows tests to inherit from MixxxTest and still register
SoundSourceProviders themselves, e.g. by instantiating CoreServices.
It also reduces log spam caused by the sound source provider
registration.