Skins: allow menubar to be styled #3372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the menubar is not part of the centralwidget which holds the stylesheet, copy the central style to the menubar as well.
Merged
|
I tried this PR on Windows 7 and I couldn't notice any difference in the menus! |
daschuer
approved these changes
Nov 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-picked from @poelzi's #3285
By default this should have no effect but allows adding individual skin styles piece by piece.
So IMO this can be merged after folks on Windows and macOS have verified that without style additions the menubar looks like before.
I'll try to catch all elements and pseudo-states with qss and also use relative sizes for checkboxes etc. to respect the custom os sizes. That doesn't have to happen here, but maybe it does, depending on what happens first: merge or style experiments.
In a few days I'll check if my Win10 installation is still alive to double-check my experiments on Windows.