Fix RUBBERBANDV3 macro in rubberbandwrapper.cpp

[Ge-lx]

Using rubberband v3 was erroring out for me at enginebufferscalerubberband.cpp:77, stalling the engine thread. The RUBBERBANDV3 macros differed between enginebufferscalerubberband.cpp and rubberbandwrapper.cpp

#14100 Only addressed enginebufferscalerubberband.cpp

[JoergAtGithub]

Welcome at Mixxx!
As a first-time contributor we need you to sign the Mixxx Contributor Agreement and comment here when you have done so. It gives us permission to distribute your contribution under the GPL v2 or later license and the Apple Mac App Store. It is also helpful for us to have contact information for contributors in case we may need it in the future.

[Ge-lx]

Thanks,
I signed the Contributor Agreement

[JoergAtGithub]

This fix should go into the stable 2.5 branch. Could you please rebase your branch to 2.5. As described here: https://github.com/mixxxdj/mixxx/wiki/Using-Git#targeting-another-base-branch

[Ge-lx]

This fix won't apply to 2.5 since this additional wrapping for RB was only introduced in 5e67d9d3eac8425c3678dac184512a4bc3a37e3a aka #13143

RB3 wasn't working for me in the release 2.5.0-1 (from arch extra repos), since the API version changed to 4.0 and #14100 was not included in that release. However the current 2.5 stable branch should work without issues.

This PR fixes #13143

[daschuer]

Ah I see, the issue is fixed in the 2.5 branch:

mixxx/src/engine/bufferscalers/enginebufferscalerubberband.cpp

Line 14 in c327cf1

#define RUBBERBANDV3 (RUBBERBAND_API_MAJOR_VERSION >= 3 || \

[daschuer]

LGTM, Thank you.