Skip to content

Commit fe90b3a

Browse files
committed
code review feedback
1 parent 6719f8c commit fe90b3a

File tree

3 files changed

+405
-456
lines changed

3 files changed

+405
-456
lines changed

src/androidTest/java/com/mixpanel/android/mpmetrics/MixpanelBasicTest.java

Lines changed: 0 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -1337,57 +1337,6 @@ protected AnalyticsMessages getAnalyticsMessages() {
13371337
assertTrue(found.getJSONObject("properties").has("$bluetooth_version"));
13381338
}
13391339

1340-
// @Test
1341-
// public void testConfiguration() {
1342-
// final ApplicationInfo appInfo = new ApplicationInfo();
1343-
// appInfo.metaData = new Bundle();
1344-
// appInfo.metaData.putInt("com.mixpanel.android.MPConfig.BulkUploadLimit", 1);
1345-
// appInfo.metaData.putInt("com.mixpanel.android.MPConfig.FlushInterval", 2);
1346-
// appInfo.metaData.putInt("com.mixpanel.android.MPConfig.DataExpiration", 3);
1347-
// appInfo.metaData.putBoolean("com.mixpanel.android.MPConfig.AutoShowMixpanelUpdates", false);
1348-
// appInfo.metaData.putBoolean("com.mixpanel.android.MPConfig.DisableGestureBindingUI", true);
1349-
// appInfo.metaData.putBoolean("com.mixpanel.android.MPConfig.DisableEmulatorBindingUI", true);
1350-
// appInfo.metaData.putBoolean("com.mixpanel.android.MPConfig.DisableAppOpenEvent", true);
1351-
//
1352-
// appInfo.metaData.putString("com.mixpanel.android.MPConfig.EventsEndpoint", "EVENTS ENDPOINT");
1353-
// appInfo.metaData.putString("com.mixpanel.android.MPConfig.PeopleEndpoint", "PEOPLE ENDPOINT");
1354-
// appInfo.metaData.putString("com.mixpanel.android.MPConfig.GroupsEndpoint", "GROUPS ENDPOINT");
1355-
// appInfo.metaData.putString("com.mixpanel.android.MPConfig.DecideEndpoint", "DECIDE ENDPOINT");
1356-
//
1357-
// final PackageManager packageManager = new MockPackageManager() {
1358-
// @Override
1359-
// public ApplicationInfo getApplicationInfo(String packageName, int flags) {
1360-
// assertEquals(packageName, "TEST PACKAGE NAME");
1361-
// assertTrue((flags & PackageManager.GET_META_DATA) == PackageManager.GET_META_DATA);
1362-
// return appInfo;
1363-
// }
1364-
// };
1365-
//
1366-
// final Context context = new MockContext() {
1367-
// @Override
1368-
// public String getPackageName() {
1369-
// return "TEST PACKAGE NAME";
1370-
// }
1371-
//
1372-
// @Override
1373-
// public PackageManager getPackageManager() {
1374-
// return packageManager;
1375-
// }
1376-
// };
1377-
//
1378-
// final MPConfig testConfig = MPConfig.readConfig(context);
1379-
// assertEquals(1, testConfig.getBulkUploadLimit());
1380-
// assertEquals(2, testConfig.getFlushInterval());
1381-
// assertEquals(3, testConfig.getDataExpiration());
1382-
// assertEquals(true, testConfig.getDisableEmulatorBindingUI());
1383-
// assertEquals(true, testConfig.getDisableGestureBindingUI());
1384-
// assertEquals(true, testConfig.getDisableAppOpenEvent());
1385-
// assertEquals(false, testConfig.getAutoShowMixpanelUpdates());
1386-
// assertEquals("EVENTS ENDPOINT", testConfig.getEventsEndpoint());
1387-
// assertEquals("PEOPLE ENDPOINT", testConfig.getPeopleEndpoint());
1388-
// assertEquals("DECIDE ENDPOINT", testConfig.getDecideEndpoint());
1389-
// }
1390-
13911340
@Test
13921341
public void test2XUrls() {
13931342
final String twoXBalok = InAppNotification.sizeSuffixUrl("http://images.mxpnl.com/112690/1392337640909.49573.Balok_first.jpg", "@BANANAS");

0 commit comments

Comments
 (0)