You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks a lot for this crate. I've really enjoyed using it.
I had some issues with timings where I couldn't figure out why my loop was slower than the TextDiff::from_lines() call. Instrumentation led me to finding out the iter_inline_changes() have a static cap at 500ms. I think it would be good to be able to specify a deadline for this function too. An issue where this shows up is in the terminal-inline.rs example, where if you have a sufficiently large file and have a small timeout for the TextDiff::from_lines(), the loop afterwards can still add 500ms.
Let me know if you think it makes sense, and I'll try to put together a PR if I get the time.
Thanks!
The text was updated successfully, but these errors were encountered:
Hi!
Thanks a lot for this crate. I've really enjoyed using it.
I had some issues with timings where I couldn't figure out why my loop was slower than the
TextDiff::from_lines()
call. Instrumentation led me to finding out theiter_inline_changes()
have a static cap at 500ms. I think it would be good to be able to specify a deadline for this function too. An issue where this shows up is in theterminal-inline.rs
example, where if you have a sufficiently large file and have a small timeout for theTextDiff::from_lines()
, the loop afterwards can still add 500ms.Let me know if you think it makes sense, and I'll try to put together a PR if I get the time.
Thanks!
The text was updated successfully, but these errors were encountered: