Fix glob! input_file on Windows #371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitsuhiko
requested changes
Jun 11, 2023
src/runtime.rs
Outdated
| .ok() | ||
| .and_then(|s| { | ||
| s.strip_prefix(self.cargo_workspace.as_path()) | ||
| s.strip_prefix(self.cargo_workspace.canonicalize().unwrap()) |
Owner
There was a problem hiding this comment.
Unfortunately canonicalize can fail quite commonly. Ideally the error here is swallowed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #336
The issue is caused due to not canonicalize the stripped prefix when localizing the path.
For example in my environment i get
"D:\\Rust\\insta"to strip from"\\\\?\\D:\\Rust\\insta\\tests\\inputs\\goodbye.txt"while when canonicalized becomes the correct prefix"\\\\?\\D:\\Rust\\insta".I used unwrap with the assumption that if canonicalize fails the previous call to canonicalize would also fail and it doesn't arrive at the unwrap.