Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Spring to 5.1.8.RELEASE and spring-security-oauth2 to 2.3.6.RELEASE #1496

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

angelusGJ
Copy link

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #1496 into master will increase coverage by <.01%.
The diff coverage is 28.57%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1496      +/-   ##
============================================
+ Coverage     25.21%   25.21%   +<.01%     
+ Complexity      912      907       -5     
============================================
  Files           209      209              
  Lines         11689    11647      -42     
  Branches       2116     2117       +1     
============================================
- Hits           2947     2937      -10     
+ Misses         8227     8195      -32     
  Partials        515      515
Impacted Files Coverage Δ Complexity Δ
...impl/DefaultJWTEncryptionAndDecryptionService.java 73.72% <ø> (ø) 29 <0> (ø) ⬇️
...2/service/impl/BlacklistAwareRedirectResolver.java 100% <ø> (ø) 3 <0> (-5) ⬇️
...client/service/impl/StaticSingleIssuerService.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...id/connect/config/ConfigurationPropertiesBean.java 50.84% <0%> (-1.79%) 16 <0> (ø)
...n/java/org/mitre/openid/connect/web/ClientAPI.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...rvice/impl/UriEncodedClientUserDetailsService.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ect/web/ProtectedResourceRegistrationEndpoint.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...connect/web/DynamicClientRegistrationEndpoint.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...service/impl/StaticServerConfigurationService.java 50% <100%> (ø) 3 <1> (ø) ⬇️
...t/client/service/impl/ThirdPartyIssuerService.java 78.57% <100%> (ø) 9 <1> (ø) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc6bd4b...ab859ae. Read the comment docs.

@@ -66,7 +65,7 @@ public RegisteredClient getClientConfiguration(ServerConfiguration issuer) {
return clients.get(issuer.getIssuer());
}

@PostConstruct
@Override
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this change made? We moved to using PostConstruct many years ago, so I'm not sure why we'd move back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants