-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch Plugins to use Tracing crate Logging and Forward Plugin Logging to Hipcheck core stderr/stdout #968
Conversation
d9bd176
to
e4ecc93
Compare
7a4e4f1
to
ebcd05d
Compare
86db15f
to
51dffa6
Compare
534c726
to
9dec34f
Compare
@KirilldogU please resolve the merge conflicts. probably a rebase on |
b881b2e
to
771d056
Compare
771d056
to
f7e212f
Compare
8403fd2
to
c31859a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, good work Kirill!
9e9d9d1
to
af8a218
Compare
… to hc-core output Signed-off-by: Kirill Usubyan <kusubyan@mitre.org>
af8a218
to
26e2f48
Compare
The requested change is implemented. The input is processed with a case/match, and if necessary the error is logged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me! Thanks Kirill for responding to all the feedback!
Resolves #381 and #933.
This PR switches the Hipcheck plugins to use the tracing crate for logging instead of the logging crate (as will be done on Hipcheck core).
It also forwards the logging output of plugins to the stderr/stdout output of Hipcheck core.
It does this through:
It also adds docs in the sdk on how to use the init_logger() feature.