-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add RFD describing support for multi-repo target #963
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: jlanson <jlanson@mitre.org>
Signed-off-by: Julian Lanson <jlanson@mitre.org>
Regarding the Then, when resolving targets from a multi-target seed, any that point directly to Git URLs could be resolved to |
|
||
As an alternative to intra-process parallelization with async code, we could | ||
spawn Hipcheck subprocesses that each communicate with their own copies of the | ||
plugin processes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably would also want to produce reports as we run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, remembering more of what I meant by the comment above. I think this section should have one more paragraph added explaining that when we're executing analyses in parallel we should be printing reports as they're finished. This avoids holding reports in memory and means we provide a more responsive user experience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd presume for multi-target we'd want to offer some kind of "summary" printing option? and/or print the full report as JSON to a target folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the option to print a JSON report to a target folder, even for a single target run, is something I brought up in one of the discussions last week. At least one Hipcheck user is going that already as part of a pipeline that includes Hipcheck. They do it now by piping the JSON output from stdout to a file, but we could make a flag to handle that ourselves. Happy to make an issue for that if we think it's a good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some thoughts. Happy to discuss further.
|
||
As an alternative to intra-process parallelization with async code, we could | ||
spawn Hipcheck subprocesses that each communicate with their own copies of the | ||
plugin processes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, remembering more of what I meant by the comment above. I think this section should have one more paragraph added explaining that when we're executing analyses in parallel we should be printing reports as they're finished. This avoids holding reports in memory and means we provide a more responsive user experience.
Signed-off-by: jlanson <jlanson@mitre.org>
Resolves #962 .
Currently a very rough draft, perhaps too vague to be an RFD as-is. I'm looking for feedback from people who know the target resolution, salsa, and Session subsystems, then I can iterate on the content.
(EDIT from Andrew: Rendered)