-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Magma #2874
Merged
Merged
Magma #2874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enable cors in server * cors now working with login api * return status 401 on wrong credentials * cleaning up the app_svc file a bit * change logout endpoint to stop serving template * CORS now working on localhost:3000 * Add aiohttp-cors to requirements file * Removing magma as a submodule in order to pass git tests * Remove magma submodule * Add back optional param for requirements * Add compiled front-end dist directory Co-authored-by: Adam Gaudreau <agaudreau@mitre.org> Co-authored-by: Palmer <zpalmer@mm273285-pc.lan> Co-authored-by: JamieScottC <scott.jams@gmail.com>
elegantmoose
commented
Feb 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for merge.
Continue to work on issues:
- pytest asyncio bug for certain GET requests
- Operation graph edge display
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Corresponding Magma changes to core.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: