Fix for issue preventing default layers from being loaded #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @wietze, Thank you for finding this bug and submitting the merge request. Everything looks good and I'll be merging it into develop, and then master, later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v2.3 of the navigator, even when the Navigator is opened without the
layerURLparameter set, it assumes it was (due to a logic error) and will never check if theenabledoption underdefault_layersinconfig.jsonis set totrue.This commit fixes the issue by checking if the result of
getNamedFragmentValue()is not null and its length greater than 0.Tested in Chrome 77.