Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ansible_mitogen: Remove restrictive whitelist of modules served from controller #1012

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

ansible_mitogen: Remove restrictive whitelist of modules served from controller #1012

wants to merge 1 commit into from

Conversation

moreati
Copy link
Member

@moreati moreati commented Jul 28, 2023

fixes #1011

@moreati moreati changed the title Fix and test ansible_mitogen responder Fix and test ansible_mitogen module responder Jul 28, 2023
@moreati moreati force-pushed the issue1011-import-handler branch 7 times, most recently from 4620ccb to fb4ae24 Compare July 28, 2023 22:07
@moreati moreati changed the title Fix and test ansible_mitogen module responder ansible_mitogen: Remove restrictive whitelist of modules served from controller Jul 28, 2023
@moreati
ansible_mitogen: Fix errant ModuleNotFoundError blacklist exceptions
823ee90 
Current module whitelist/blacklist behaviour is to reject any module not on
the whitelist if the whitelist is populated. Adding `ansible` and
`ansible_mitogen` to the whitelist effectively blocklisted every other Python
module/package, negating much of the benefit of Mitogen.

Fixes mitogen-hq#1011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ansible_mitogen blacklists third-party modules
1 participant
@moreati