Skip to content

Create country field unit tests #3164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cp-at-mit merged 9 commits into from
Jan 5, 2026
Merged

Create country field unit tests #3164

cp-at-mit merged 9 commits into from
Jan 5, 2026

Conversation

@cp-at-mit
Copy link
Contributor

@cp-at-mit cp-at-mit commented Dec 22, 2025

What are the relevant tickets?

NA

Description (What does it do?)

Adds unit test coverage for create_country_field and optimizes the method.

How can this be tested?

Tests should pass

@github-actions
Copy link

github-actions bot commented Dec 22, 2025

OpenAPI Changes

Show/hide ## Changes for v0.yaml: 
## Changes for v0.yaml:


## Changes for v1.yaml:


## Changes for v2.yaml:

Unexpected changes? Ensure your branch is up-to-date with main (consider rebasing).

pre-commit-ci bot and others added 6 commits December 22, 2025 18:27
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
6fa0ec8 
for more information, see https://pre-commit.ci
@cp-at-mit
Update country field test to check alphabetical ordering
6f19333 
Renamed and updated the test for create_country_field to verify that choices are ordered alphabetically, not by database order. Adjusted expected choices accordingly.
@cp-at-mit
Merge branch 'create_country_field-unit-tests' of https://github.com/…
461a496 
…mitodl/mitxonline into create_country_field-unit-tests
@cp-at-mit
Remove unused variables in FlexiblePricingFormBuilder tests
56b0eda
@cp-at-mit
ruff
09809ba
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
b0cb193 
for more information, see https://pre-commit.ci
@cp-at-mit cp-at-mit marked this pull request as ready for review December 22, 2025 20:16
@jkachel jkachel self-assigned this Jan 5, 2026
jkachel
jkachel approved these changes Jan 5, 2026
View reviewed changes
Copy link
Contributor

@jkachel jkachel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@cp-at-mit cp-at-mit merged commit b80918d into main Jan 5, 2026
9 checks passed
@odlbot odlbot mentioned this pull request Jan 5, 2026
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkachel jkachel jkachel approved these changes

Assignees

@jkachel jkachel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cp-at-mit @jkachel