Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mitchtabian/Clean-Notes
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: mitchtabian/Clean-Notes
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: bug-fix-2
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 9 files changed
  • 1 contributor

Commits on Jun 16, 2020

  1. 1. Bugs: 

    	1. Logic broken in SyncNotes
		- `checkIfCachedNoteRequiresUpdate` must convert the string dates to Timestamps or something that's comparable. Right now just comparing the strings which doens't make sense.
	2. Logic broken in SyncDeletesNotesTest
		- `deleteNetworkNotes_confirmCacheSync` must insert into `deletes` node after removing from `notes` node. That will mimic the correct behavior in production.
		- https://gist.github.com/mitchtabian/66c50710fbd93fb8ba0cb48b4179c7f4
	3. Logic is broken in UpdateNoteTest
		- `updateNote_success_confirmNetworkAndCacheUpdated` is creating a new note with a different title, body and **created_at** date. The created_at date cannot change.
		- https://gist.github.com/mitchtabian/25544be2465f452dcc0a74ecd7ca0000
2. Trigger the bugs:
	- Change DependencyContainer to this (providing a different hashmap to the data sources) if will cause these two test failures:
		- https://gist.github.com/mitchtabian/2fc69f47b55b43b4b9d2da2516603eb5
    @mitchtabian
    mitchtabian committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    cc3f90e View commit details
    Browse the repository at this point in the history
Loading