Refactor to use model methods instead of static properties.

Author: mitchdav

src/HasStripeId.php

@@ -3,10 +3,10 @@
 namespace Mitchdav\StripeIds;
 
 /**
- * @property static $stripeIdsAlphabet
- * @property static $stripeIdsLength
- * @property static $stripeIdsSeparator
- * @property static $stripeIdsPrefix
+ * @property string $stripeIdAlphabet
+ * @property int $stripeIdLength
+ * @property string $stripeIdSeparator
+ * @property string $stripeIdPrefix
  */
 trait HasStripeId
 {
@@ -15,12 +15,12 @@ protected static function bootHasStripeId()
         static::creating(function ($model) {
             if (!$model->getKey()) {
                 $stripeIds = new StripeIds(
-                    self::$stripeIdsAlphabet ?? config('stripe-ids.alphabet'),
-                    self::$stripeIdsLength ?? config('stripe-ids.length'),
-                    self::$stripeIdsSeparator ?? config('stripe-ids.separator'),
+                    $model->getStripeIdAlphabet(),
+                    $model->getStripeIdLength(),
+                    $model->getStripeIdSeparator()
                 );
 
-                $model->{$model->getKeyName()} = $stripeIds->id(self::$stripeIdsPrefix);
+                $model->{$model->getKeyName()} = $stripeIds->id($model->getStripeIdPrefix());
             }
         });
     }
@@ -34,4 +34,24 @@ public function getKeyType()
     {
         return 'string';
     }
+
+    public function getStripeIdAlphabet()
+    {
+        return $this->stripeIdAlphabet ?? config('stripe-ids.alphabet');
+    }
+
+    public function getStripeIdLength()
+    {
+        return $this->stripeIdLength ?? config('stripe-ids.length');
+    }
+
+    public function getStripeIdSeparator()
+    {
+        return $this->stripeIdSeparator ?? config('stripe-ids.separator');
+    }
+
+    public function getStripeIdPrefix()
+    {
+        return $this->stripeIdPrefix;
+    }
 }

tests/HasStripeIdTest.php

@@ -13,12 +13,15 @@ public function it_generates_an_id_during_creating_event()
         /** @var DefaultModel $model */
         $model = DefaultModel::query()->make();
 
+        $prefix = $model->getStripeIdPrefix();
+        $separator = $model->getStripeIdSeparator();
+
         $this->assertNull($model->getKey());
 
         $model->save();
 
         $this->assertNotNull($model->getKey());
-        $this->assertStringStartsWith(DefaultModel::$stripeIdsPrefix, $model->getKey());
+        $this->assertStringStartsWith($prefix.$separator, $model->getKey());
     }
 
     /** @test */
@@ -27,20 +30,22 @@ public function it_generates_an_id_using_overridden_properties()
         /** @var OverriddenModel $model */
         $model = OverriddenModel::query()->make();
 
+        $prefix = $model->getStripeIdPrefix();
+        $alphabet = $model->getStripeIdAlphabet();
+        $length = $model->getStripeIdLength();
+        $separator = $model->getStripeIdSeparator();
+
         $this->assertNull($model->getKey());
 
         $model->save();
 
         $this->assertNotNull($model->getKey());
-        $this->assertStringStartsWith(OverriddenModel::$stripeIdsPrefix, $model->getKey());
+        $this->assertStringStartsWith($prefix.$separator, $model->getKey());
 
-        $pattern = '/^'.OverriddenModel::$stripeIdsPrefix.OverriddenModel::$stripeIdsSeparator.'['.OverriddenModel::$stripeIdsAlphabet.']+$/';
+        $pattern = '/^'.$prefix.$separator.'['.$alphabet.']+$/';
 
         $this->assertEquals(1, preg_match($pattern, $model->getKey()));
-        $this->assertEquals(
-            strlen(OverriddenModel::$stripeIdsPrefix) + strlen(OverriddenModel::$stripeIdsSeparator) + OverriddenModel::$stripeIdsLength,
-            strlen($model->getKey())
-        );
+        $this->assertEquals(strlen($prefix) + strlen($separator) + $length, strlen($model->getKey()));
     }
 
     /** @test */

tests/Models/DefaultModel.php

@@ -9,9 +9,9 @@ class DefaultModel extends Model
 {
     use HasStripeId;
 
-    public static $stripeIdsPrefix = 'dm';
-
     protected static $unguarded = true;
 
+    public $stripeIdPrefix = 'dm';
+
     protected $table = 'test_models';
 }

tests/Models/OverriddenModel.php

@@ -9,15 +9,15 @@ class OverriddenModel extends Model
 {
     use HasStripeId;
 
-    public static $stripeIdsAlphabet = 'ABCDEF123456';
+    protected static $unguarded = true;
 
-    public static $stripeIdsLength = 10;
+    public $stripeIdAlphabet = 'ABCDEF123456';
 
-    public static $stripeIdsSeparator = ':';
+    public $stripeIdLength = 10;
 
-    public static $stripeIdsPrefix = 'om';
+    public $stripeIdSeparator = ':';
 
-    protected static $unguarded = true;
+    public $stripeIdPrefix = 'om';
 
     protected $table = 'test_models';
 }