Skip to content
This repository has been archived by the owner on Dec 23, 2018. It is now read-only.

support for Java 8 and LibreOffice 5 #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EyadA
Copy link

@EyadA EyadA commented Jul 29, 2016

No description provided.

@EyadA EyadA closed this Jul 29, 2016
@EyadA EyadA reopened this Jul 29, 2016
@llwp
Copy link

llwp commented Aug 20, 2016

@mirkonasato looking around I don't see anyone maintaining this yet and references to it still being used... would it be better to refer to a fork or add one or more maintainers here in your project?

Your call - - it looks like some people have tried to help out here and there. (ie @EyadA here)

@mirkonasato
Copy link
Owner

@llwp the readme (last updated 4 years ago) says

I started this project back in 2003, but I am no longer maintaining it. I moved the code here at GitHub in the hope that a well-maintained fork will emerge.

If you look at the forks graph you can see which ones are active.

@EugenMayer
Copy link

EugenMayer commented Aug 21, 2016

@llwp since i found that "best fork seach" pretty complex and time consuming, i just though i share my result. I would expect https://github.com/nuxeo/jodconverter to be the most advanced / maintain fork. I am not biased - if you find any other interesting options, feel free to share them

They have java8 and libreoffice8 support - i am using both

@mirkonasato the problem with just "find a other fork" is that effort is heavily spreaded across now surely 20 substantial forks. the reason behind that is, that you did never opt in to either support a fork as a successor nor ever opened you repo for contributors.

Neither the first or the latter i can understand, considering, that you are not maintaining it at all. I really value your work, but you are making this issue even worse - sorry to tell you that

@mirkonasato
Copy link
Owner

@EugenMayer if somebody offers to officially become the new maintainer of this project I would be more than happy to endorse them. Unfortunately nobody contacted me to that purpose so far.

@EugenMayer
Copy link

EugenMayer commented Aug 21, 2016

@mirkonasato maybe you should go this step on your own - your repo is dead by definition. Nothing happens and it will not help anybody. Not as "a past reference" - there is nothing like this needed.

Probably any of the advanced forks is a better alternative by definition, so you might be just bold picking one and trying to focus forces on one fork. Please have a look at https://github.com/nuxeo/jodconverter/commits/3.0-NX they seem to constantly maintain them or at least merge them.

We do for now actually maintain a private fork in our private repo, merging from different sources - we have Business interest in jodconvert and we are using it since the really early days already. Still i would not say we are doing any active work right now, even though we gathered quiet some java-expertise the last couple of years - so that might change.

All i want to say is, its worse not taking a decision then doing one which is not optimal right now. Pick one you like most or see the highest potential in, for me its nuxeon + cherry picking. I would probably offer myself as a maintainer at some point, but i do not feel confident doing so - also running to many OS projects right now.

Please take your time to pick a new successor for your wonderful and valuable work!

@mirkonasato
Copy link
Owner

Yes this repo is unmaintained, and it clearly says so in the readme. So I'm not entirely sure what the issue is.

The Nuxeo fork has some recent commits, but I don't know what their plans are, if they're only maintaining it for use it in their own project, or see it as a a general purpose library useful outside of Nuxeo. That's why I'd rather not point people to any specific fork without a conversation with its maintainer.

@EugenMayer
Copy link

@mirkonasato its def. general purpose ( nuxeon ) since i use their fork, i can at least say this (for now)

@GhaziTriki
Copy link

Hello @mirkonasato, I am interested on maintaining the repository and getting it alive again. How can can I get in touch with you?

@cstrobbe
Copy link

@EugenMayer It looks like "we" (i.e. whoever is interested in the project) will need to pick a repository we want to support, e.g. the one by @nuxeo, as you suggested, or the one by @EyadA. @GhaziTriki currently has no fork or copy of the project. I haven't checked whether there are any forks worth considering.

@EugenMayer
Copy link

@cstrobbe yeah thats what happens if you over-protect your project - you more or less kill it by protected it - thats what happens here.

The author wants to find the "best successor" possible, do not want to make a mistake by "picking the wrong one" and thus waits - forever.

During that, effort spreads, more, and more - 431 forks. Literally more forks then stars - thats exactly the point.

idk how to make a proper successor to join the forces though - you offer any strategy?

@cstrobbe
Copy link

@EugenMayer I don't have a strategy at the moment. I found several other forks with significant modifications:

This "cluster":

This pair:

And this one:

I hope some of these people will chime in. Although this is not the ideal place for this type of discussion.

@sbraconnier
Copy link

Hey! Hello There! I'm glad to see that people are willing to help keeping this project alive. So I'll join this discussion to help you take the right decision.

First, as for the "lots of changes" of my fork, it can be explained by the fact that I looked at the original project from A to Z, commenting what I understood along the way. The original project is comments free so I thought that if we (the community) wanted to take the lead, we had to be able to read the code as a book.

The main "real" change of my fork is that it fixes a bug where an office process could be lost, resulting in a whole "JOD Converter" module corrupted (we had to restart our application server when the JOD Converter module was unresponsive). With this fork, we never encountered this problem. I added a couple of "thread safe" operations and it seems to do the trick.

The other significant change is the org.artofsolving.jodconverter.filter package, where live classes responsible to apply custom changes to a converted document. I plan to add to this package some filters that would:

  • Add an image to the converted document at a specified location
  • Add customizable text to the converted document at a specified location
  • etc...

As for the reason that I didn't merged yet the last pull request (I previously merged a first one) of joseluisll (thanks to him for his interest in my fork), it was because I felt like this pull request had nothing to do with "conversion". So, I wasn't comfortable with the fact that the "JOD Converter library" would have an insignificant name. I thought about a complete multi-module rewritten JOD "whatever" library, but I'm not sure it is really needed somewhere...

So.. to resume. I didn't ignored joseluisll pull request because I abandoned the project, but more because I had to let him know what I think was best for the project, and I failed to do so as of now (wife, kids, house, buddys... take care of myself... sometimes when I can I brush my teeth....)...

Help is welcome. And if you decide to take the lead, I'll be happy to support you.

Maybe this project is worth more than 1 submitter ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants